Review main Merged

86012[FEATURE] Ignore Fluid syntax error in <f:comment>

Simon Praetorius CR +2 V +2 Easy +37 −0 updated 09/11/24, 14:08

Commit message

This patch enables a template processor included in Fluid 4
for all Fluid instances in the Core. The template processor
strips `<f:comment>` tags from Fluid template strings before
the parsing starts. This prevents Fluid errors when invalid
Fluid code is used inside `<f:comment>`.

Original change in Fluid:
https://github.com/TYPO3/Fluid/commit/faad81a9f5d991d688e1d4c673e0d7aaf41a7e94

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Simon Praetorius uploaded patch set 1 09/11/24, 10:17

  2. Mathias Brodala commented on patch set 1 09/11/24, 10:22

    I strongly recommend explicitly saying "<f:comment>" everywhere to avoid confusion with plain HTML/XML comments.
  3. Simon Praetorius uploaded patch set 2 09/11/24, 10:24

  4. Simon Praetorius commented on patch set 2 09/11/24, 10:25

    Reply

    Done
  5. Mathias Brodala voted on patch set 2 CR +1 09/11/24, 10:27

  6. core-ci voted on patch set 1 V +1 09/11/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65416

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 09/11/24, 10:29

  8. core-ci voted on patch set 2 V +1 09/11/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65419

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 09/11/24, 11:06

  10. Guido Schmechel voted on patch set 2 CR +1 09/11/24, 11:39

  11. Benni Mack voted on patch set 2 CR +1 V +1 09/11/24, 11:43

  12. Simon Praetorius voted on patch set 2 CR +2 V +2 09/11/24, 14:08

  13. Simon Praetorius merged patch set 3 09/11/24, 14:08