Review main Merged

86013[TASK] Enable direct access to nested settings properties in fluid

Benjamin Franzke CR +2 V +2 Easy +30 −6 updated 09/12/24, 21:58

Commit message

Implement ContainerInterface in order for fluid[1] to be able
to access settings properties directly, instead of using
`{settings.all.property}`, e.g. when accessing site settings
directly via `{site.settings.mysite.brandColor}`.

[1] https://github.com/TYPO3/Fluid/issues/1001 (raised in #104896)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 09/11/24, 11:21

  2. core-ci voted on patch set 1 V +1 09/11/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65420

  3. Benni Mack voted on patch set 1 CR +1 09/11/24, 11:43

  4. Stefan Bürk voted on patch set 1 CR +1 09/12/24, 00:13

  5. Oli Bartsch commented on patch set 1 09/12/24, 19:47

    NotFoundException.php:26

    Could we name this explicitly, e.g. `SettingNotFoundException`?
  6. Benjamin Franzke uploaded patch set 2 CR +1 V +1 09/12/24, 19:52

  7. Benjamin Franzke commented on patch set 2 09/12/24, 19:52

    NotFoundException.php:26 Reply

    was inspired by `typo3/sysext/core/Classes/DependencyInjection/NotFoundException.php`, but I don't care and it seems there are more explicit cases in core. Done.
  8. Oli Bartsch voted on patch set 2 CR +1 V +1 09/12/24, 19:54

  9. core-ci voted on patch set 2 V +1 09/12/24, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65602

  10. Benni Mack voted on patch set 2 CR +1 V +1 09/12/24, 20:18

  11. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/12/24, 21:58

  12. Benjamin Franzke merged patch set 3 09/12/24, 21:58