86014[BUGFIX] Close modal windows containing an iframe on escape
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2230
Show 35 earlier messages
-
Jochen Roth uploaded patch set 1 09/11/24, 12:42
-
Jochen Roth updated the commit message in patch set 2 09/11/24, 12:45
-
core-ci voted on patch set 1 V -1 09/11/24, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65441
-
core-ci voted on patch set 2 V -1 09/11/24, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65442
-
Jochen Roth uploaded patch set 3
V -109/11/24, 12:56
-
core-ci voted on patch set 3 V +1 09/11/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65443
-
Jochen Roth updated the commit message in patch set 4
V +109/11/24, 13:14 -
core-ci voted on patch set 4 V +1 09/11/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65450
-
André Buchmann uploaded patch set 5
V +109/11/24, 14:20 -
André Buchmann updated the commit message in patch set 6 09/11/24, 14:24
-
André Buchmann voted on patch set 6 CR +1 V +1 09/11/24, 14:30
-
core-ci voted on patch set 6 V +1 09/11/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65466
-
Guido Schmechel voted on patch set 6 CR +1 V +1 10/03/24, 10:44
-
Oli Bartsch uploaded patch set 7
CR +1V +110/04/24, 10:48 -
Oli Bartsch voted on patch set 7 CR +1 V +1 10/04/24, 10:48
-
core-ci voted on patch set 7 V +1 10/04/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67072
-
Oliver Hader updated the commit message in patch set 8
CR +1V +110/18/24, 14:01 -
André Buchmann voted on patch set 8 CR +1 V +1 01/14/25, 22:39
-
Garvin Hicking commented on patch set 8 CR +1 V +1 01/14/25, 23:16
(not 100% sure to put this into 12.4, but fine by me) -
Andreas Kienast commented on patch set 8 01/15/25, 07:16
I'd welcome a more general solution as this potentially affects all modal windows. -
Andreas Kienast uploaded patch set 9
CR +1V +101/15/25, 07:41 -
Andreas Kienast commented on patch set 9 01/15/25, 07:42
Reply
Done -
core-ci voted on patch set 9 V +1 01/15/25, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72503
-
Oli Bartsch voted on patch set 9 CR +1 V +1 01/15/25, 07:51
-
Oli Bartsch updated the commit message in patch set 10
CR +1V +101/15/25, 07:51 -
Oli Bartsch voted on patch set 10 CR +1 V +1 01/15/25, 07:51
-
core-ci voted on patch set 10 V +1 01/15/25, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72505
-
Garvin Hicking voted on patch set 10 CR +1 V +1 01/15/25, 09:10
-
Oli Bartsch voted on patch set 10 CR +2 V +2 01/15/25, 09:13
-
Oli Bartsch merged patch set 11 01/15/25, 09:13