Review main Merged

86015[TASK] Make modal context aware

Benjamin Kott CR +2 V +2 Hard +317 −318 updated 09/11/24, 13:57

Commit message

We are dropping the Bootstrap CSS definitions for
all modals to have more control about the styling of
the modal elements. From now on we are shipping
custom css adapted to our needs. The new modal
element styling is context aware and adapts to
light and dark color schemes.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 812

  1. Benjamin Kott uploaded patch set 1 09/11/24, 12:57

  2. Benjamin Kott uploaded patch set 2 09/11/24, 13:00

  3. Benjamin Kott uploaded patch set 3 09/11/24, 13:04

  4. core-ci voted on patch set 1 V +1 09/11/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65444

  5. core-ci voted on patch set 3 V +1 09/11/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65446

  6. core-ci voted on patch set 2 V -1 09/11/24, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65445

  7. Benjamin Kott uploaded patch set 4 V +1 09/11/24, 13:33

  8. Benjamin Franzke voted on patch set 4 CR +1 V +1 09/11/24, 13:34

  9. core-ci voted on patch set 4 V +1 09/11/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65453

  10. Andreas Nedbal voted on patch set 4 CR +1 V +1 09/11/24, 13:54

  11. Benjamin Kott voted on patch set 4 CR +2 V +2 09/11/24, 13:56

  12. Benjamin Kott merged patch set 5 09/11/24, 13:57