Review main Merged

86022[TASK] Allow using element browser in "nested" modal iframes

Oliver Hader CR +2 V +2 Easy +15 −2 updated 02/10/25, 20:23

Commit message

In case the element browser iframe was opened by another iframe
(for instance a wizard modal), the back-reference to the previous
modal iframe is now resolved from the recent modal iframe.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Oliver Hader uploaded patch set 1 09/11/24, 16:58

  2. core-ci voted on patch set 1 V -1 09/11/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65470

  3. core-ci voted on patch set 1 V +1 09/11/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65470

  4. Oli Bartsch uploaded patch set 2 V +1 02/10/25, 17:24

  5. core-ci voted on patch set 2 V +1 02/10/25, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73912

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 02/10/25, 17:33

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 02/10/25, 17:41

  8. Georg Ringer commented on patch set 2 02/10/25, 19:39

    should this also fix https://forge.typo3.org/issues/105301? that still looks the same but doesn't work for me with the patch, or different issue?
  9. Benni Mack voted on patch set 2 CR +1 V +1 02/10/25, 19:50

  10. Benni Mack commented on patch set 2 02/10/25, 19:51

    Reply

    that's a different issue I guess.
  11. Oli Bartsch commented on patch set 2 CR +2 V +2 02/10/25, 20:23

    Reply

    If I remember correct, I already looked into this once. The problem is that the "file-list-actions" component does not seem to work properly. We should check this separately again
  12. Oli Bartsch merged patch set 3 02/10/25, 20:23