Review main Merged

86024[TASK] Make dashboard context aware

Andreas Nedbal CR +2 V +2 Hard +262 −284 updated 09/13/24, 11:11

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1727

Show 12 earlier messages
  1. Andreas Nedbal uploaded patch set 1 09/11/24, 18:53

  2. core-ci voted on patch set 1 V -1 09/11/24, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65478

  1. Andreas Nedbal uploaded patch set 2 V -1 09/11/24, 19:13

  2. core-ci voted on patch set 2 V +1 09/11/24, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65481

  3. Andreas Kienast commented on patch set 2 09/12/24, 06:45

    chart-initializer.ts:98

    You may workaround this via `window.matchMedia('(prefers-color-scheme: dark)')`.
  4. Andreas Nedbal uploaded patch set 3 V +1 09/12/24, 07:52

  5. core-ci voted on patch set 3 V +1 09/12/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65530

  6. Andreas Nedbal uploaded patch set 4 V +1 09/12/24, 08:34

  7. core-ci voted on patch set 4 V +1 09/12/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65543

  8. Andreas Nedbal commented on patch set 4 09/12/24, 08:48

    chart-initializer.ts:98 Reply

    Done
  9. Andreas Kienast uploaded patch set 5 V +1 09/12/24, 10:41

  10. Andreas Kienast commented on patch set 5 V -1 09/12/24, 10:43

    In dark mode: the label colors are off in the doughnut chart and the grid of the bar charts are not visible.
  11. core-ci voted on patch set 5 V +1 09/12/24, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65556

  12. Benjamin Kott uploaded patch set 6 V +1 09/12/24, 13:26

  13. core-ci voted on patch set 6 V -1 09/12/24, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65565

  14. core-ci commented on patch set 6 09/12/24, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65565

  15. Benjamin Kott uploaded patch set 7 V -1 09/13/24, 06:59

  16. core-ci voted on patch set 7 V +1 09/13/24, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65630

  17. Benjamin Kott uploaded patch set 8 V +1 09/13/24, 09:54

  18. core-ci voted on patch set 8 V +1 09/13/24, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65653

  19. Benjamin Kott uploaded patch set 9 V +1 09/13/24, 10:29

  20. Benjamin Kott commented on patch set 9 09/13/24, 10:33

    Reply

    should be fine,now same problem as codemirror needs reload after setting a new color-scheme
  21. Benjamin Kott commented on patch set 9 09/13/24, 10:33

    Reply

    Done
  22. core-ci voted on patch set 9 V +1 09/13/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65657

  23. Benjamin Kott voted on patch set 9 CR +1 V +1 09/13/24, 10:36

  24. Andreas Kienast voted on patch set 9 CR +2 V +2 09/13/24, 11:11

  25. Andreas Kienast merged patch set 10 09/13/24, 11:11