86026[BUGFIX] Respect order of item groups in NewContentElementWizard
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 10
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php4+34 −8
- typo3/sysext/backend/Classes/Form/Processor/SelectItemProcessor.php3+6 −1
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php+63 −0
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+24 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+55 −18
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104855-StringValueForItemGroupsGroupItemOfTt_contentCTypeColumn.rstnew+55 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Important-104855-PositionalInformationForTCAGroupsInNewContentElementWizard.rstnew+55 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+68 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+171 −2
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+23 −6
Review log 2636
Show 611 earlier messages
-
Nikita Hovratov uploaded patch set 1 09/11/24, 20:14
-
core-ci voted on patch set 1 V -1 09/11/24, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65489
-
Nikita Hovratov uploaded patch set 2
V -109/12/24, 07:39 -
core-ci voted on patch set 2 V -1 09/12/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65529
-
Nikita Hovratov uploaded patch set 3
V -109/12/24, 16:55 -
Nikita Hovratov uploaded patch set 4 09/12/24, 16:55
-
Nikita Hovratov uploaded patch set 5 09/12/24, 16:58
-
core-ci voted on patch set 3 V -1 09/12/24, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65591
-
core-ci voted on patch set 4 V -1 09/12/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65592
-
core-ci voted on patch set 5 V -1 09/12/24, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65593
-
Nikita Hovratov uploaded patch set 6
V -109/12/24, 17:11
-
Nikita Hovratov uploaded patch set 7 09/12/24, 17:14
-
core-ci voted on patch set 7 V +1 09/12/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65597
-
Sébastien Delcroix commented on patch set 7 09/12/24, 19:00
-
Nikita Hovratov voted on patch set 7 V -1 09/12/24, 19:49
-
Nikita Hovratov uploaded patch set 8
V +109/12/24, 20:59 -
Nikita Hovratov commented on patch set 8 09/12/24, 21:00
NewContentElementController.php:300ReplyDone -
core-ci voted on patch set 8 V +1 09/12/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65603
-
Sébastien Delcroix commented on patch set 8 09/12/24, 21:24
NewContentElementController.php:231Maybe don't use $contentElementAndPluginSubTypeWizards as an intermediate variable by calling $this->loadAvailableWizardsFromContentElements() and $this->loadAvailableWizardsFromPluginSubTypes() directly as arguments of $this->mergeContentElementAndPluginSubTypeWizards() ? -
Nikita Hovratov uploaded patch set 9
V +109/12/24, 21:28 -
Nikita Hovratov commented on patch set 9 09/12/24, 21:29
NewContentElementController.php:231Replythanks! I think auto-refactoring messed that up for me. -
core-ci voted on patch set 9 V +1 09/12/24, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65607
-
Lina Wolf commented on patch set 9 V +1 09/13/24, 09:09
Tested with tt_address and examples installed and works as expected -
Lina Wolf commented on patch set 10
V +109/13/24, 09:16Published edit on patch set 9. -
Lina Wolf commented on patch set 10 09/13/24, 09:17
SelectItemProcessor.php:66Could we maybe apply ucfirst() here? That would give nicer fallbacks -
Lina Wolf voted on patch set 10 V +1 09/13/24, 09:17
-
core-ci voted on patch set 10 V +1 09/13/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65644
-
Nikita Hovratov commented on patch set 10 09/13/24, 09:53
SelectItemProcessor.php:66ReplyWe can discuss this, but it's not part of the patch to change this behavior. -
Lina Wolf commented on patch set 10 09/13/24, 10:33
SelectItemProcessor.php:66ReplyAcknowledged -
Lina Wolf commented on patch set 10 CR +1 09/13/24, 10:34
Code looks good to me as far as I can tell (not deep into the topic) -
Nikita Hovratov commented on patch set 10 09/27/24, 10:20
bump -
Nikita Hovratov commented on patch set 10 10/08/24, 13:00
bump -
Nikita Hovratov uploaded patch set 11
CR +1V +110/08/24, 13:11 -
core-ci voted on patch set 11 V +1 10/08/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67378
-
Lina Wolf voted on patch set 11 CR +1 V +1 10/10/24, 09:41
-
Nikita Hovratov abandoned the change 12/05/24, 20:15
too expensive solution
NewContentElementController.php:300