Review main Abandoned

86026[BUGFIX] Respect order of item groups in NewContentElementWizard

Nikita Hovratov CR 0 V 0 Hard +554 −35 updated 12/05/24, 20:15

Commit message

Since the change of registering wizard items groups with TCA in #102834
the order of groups can't be changed anymore in the wizard.

This is now fixed by storing the order in TCA array "itemGroups" in
addition to the label. Due to the change of structure of the array,
a TCA migration is necessary. Also, previously applied TCA/Overrides
for the group label will delete the position information. This will be
not considered breaking, but will trigger a deprecation level log entry.

Important: This is only done for table tt_content and field CType for
now. In future this could be extended for other type fields of other
tables as well, when a creation wizard is provided for them.

Additional drive-by fix: The plugin subtype labels would override the
CType labels if a group with the same identifier exists. This is now
avoided by doing a more controlled merge of the arrays.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 10

Review log 2636

Show 611 earlier messages
  1. Nikita Hovratov uploaded patch set 1 09/11/24, 20:14

  2. core-ci voted on patch set 1 V -1 09/11/24, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65489

  3. Nikita Hovratov uploaded patch set 2 V -1 09/12/24, 07:39

  4. core-ci voted on patch set 2 V -1 09/12/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65529

  5. Nikita Hovratov uploaded patch set 3 V -1 09/12/24, 16:55

  6. Nikita Hovratov uploaded patch set 4 09/12/24, 16:55

  7. Nikita Hovratov uploaded patch set 5 09/12/24, 16:58

  8. core-ci voted on patch set 3 V -1 09/12/24, 17:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65591

  9. core-ci voted on patch set 4 V -1 09/12/24, 17:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65592

  10. core-ci voted on patch set 5 V -1 09/12/24, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65593

  11. Nikita Hovratov uploaded patch set 6 V -1 09/12/24, 17:11

  1. Nikita Hovratov uploaded patch set 7 09/12/24, 17:14

  2. core-ci voted on patch set 7 V +1 09/12/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65597

  3. Sébastien Delcroix commented on patch set 7 09/12/24, 19:00

    NewContentElementController.php:300

    I've noticed that there is an overwrite of the wizard group 'default' header for the 'CType' itemGroup with the one of 'list_type" when at least one list_type plugin is enabled. See : https://forge.typo3.org/issues/104855#note-4
  4. Nikita Hovratov voted on patch set 7 V -1 09/12/24, 19:49

  5. Nikita Hovratov uploaded patch set 8 V +1 09/12/24, 20:59

  6. Nikita Hovratov commented on patch set 8 09/12/24, 21:00

    NewContentElementController.php:300 Reply

    Done
  7. core-ci voted on patch set 8 V +1 09/12/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65603

  8. Sébastien Delcroix commented on patch set 8 09/12/24, 21:24

    NewContentElementController.php:231

    Maybe don't use $contentElementAndPluginSubTypeWizards as an intermediate variable by calling $this->loadAvailableWizardsFromContentElements() and $this->loadAvailableWizardsFromPluginSubTypes() directly as arguments of $this->mergeContentElementAndPluginSubTypeWizards() ?
  9. Nikita Hovratov uploaded patch set 9 V +1 09/12/24, 21:28

  10. Nikita Hovratov commented on patch set 9 09/12/24, 21:29

    NewContentElementController.php:231 Reply

    thanks! I think auto-refactoring messed that up for me.
  11. core-ci voted on patch set 9 V +1 09/12/24, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65607

  12. Lina Wolf commented on patch set 9 V +1 09/13/24, 09:09

    Tested with tt_address and examples installed and works as expected
  13. Lina Wolf commented on patch set 10 V +1 09/13/24, 09:16

    Published edit on patch set 9.
  14. Lina Wolf commented on patch set 10 09/13/24, 09:17

    SelectItemProcessor.php:66

    Could we maybe apply ucfirst() here? That would give nicer fallbacks
  15. Lina Wolf voted on patch set 10 V +1 09/13/24, 09:17

  16. core-ci voted on patch set 10 V +1 09/13/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65644

  17. Nikita Hovratov commented on patch set 10 09/13/24, 09:53

    SelectItemProcessor.php:66 Reply

    We can discuss this, but it's not part of the patch to change this behavior.
  18. Lina Wolf commented on patch set 10 09/13/24, 10:33

    SelectItemProcessor.php:66 Reply

    Acknowledged
  19. Lina Wolf commented on patch set 10 CR +1 09/13/24, 10:34

    Code looks good to me as far as I can tell (not deep into the topic)
  20. Nikita Hovratov commented on patch set 10 09/27/24, 10:20

    bump
  21. Nikita Hovratov commented on patch set 10 10/08/24, 13:00

    bump
  22. Nikita Hovratov uploaded patch set 11 CR +1 V +1 10/08/24, 13:11

  23. core-ci voted on patch set 11 V +1 10/08/24, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67378

  24. Lina Wolf voted on patch set 11 CR +1 V +1 10/10/24, 09:41

  25. Nikita Hovratov abandoned the change 12/05/24, 20:15

    too expensive solution