86028[TASK] Implement readonly site settings
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Frank Nägler +1
- Sebastian Iffland +1
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 18
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts+13 −1
- Build/Sources/TypeScript/backend/settings/type/base.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/bool.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/color.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/int.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/number.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/string.ts+1 −0
- Build/Sources/TypeScript/backend/settings/type/stringlist.ts+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.js+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/base.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/bool.js+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/color.js+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/int.js+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/number.js+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/string.js+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/type/stringlist.js+4 −3
- typo3/sysext/core/Classes/Settings/SettingDefinition.php+1 −0
- typo3/sysext/core/Classes/Site/SiteSettingsService.php+3 −0
Review log 1317
-
Benjamin Franzke uploaded patch set 1 09/11/24, 20:35
-
core-ci voted on patch set 1 V +1 09/11/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65494
-
Benjamin Franzke rebased onto patch set 2
V +109/13/24, 09:30 -
core-ci voted on patch set 2 V +1 09/13/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65647
-
Andreas Kienast commented on patch set 2 09/13/24, 10:05
For whatever reason, `readonly` doesn't have a visual effect on checkboxes. -
Benjamin Franzke uploaded patch set 3
V +109/13/24, 11:12 -
Benjamin Franzke commented on patch set 3 09/13/24, 11:12
Reply
good catch, fixed via `disabled` – https://stackoverflow.com/a/12971018 -
core-ci voted on patch set 3 V +1 09/13/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65667
-
Andreas Kienast voted on patch set 3 CR +1 V +1 09/16/24, 10:04
-
Benjamin Franzke rebased onto patch set 4
CR +1V +109/16/24, 12:37 -
core-ci voted on patch set 4 V +1 09/16/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65884
-
Andreas Kienast voted on patch set 4 CR +1 V +1 09/16/24, 13:00
-
Sebastian Iffland voted on patch set 4 CR +1 09/16/24, 14:47
-
Frank Nägler voted on patch set 4 CR +1 09/16/24, 15:02
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/16/24, 15:06
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 09/16/24, 15:21
-
Benjamin Franzke merged patch set 5 09/16/24, 15:21