Review main Merged

86028[TASK] Implement readonly site settings

Benjamin Franzke CR +2 V +2 Normal +42 −12 updated 09/16/24, 15:21

Commit message

In preparation for readonly system settings, settings
definitions now suppot a readonly attribute.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Sebastian Iffland +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 1317

  1. Benjamin Franzke uploaded patch set 1 09/11/24, 20:35

  2. core-ci voted on patch set 1 V +1 09/11/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65494

  3. Benjamin Franzke rebased onto patch set 2 V +1 09/13/24, 09:30

  4. core-ci voted on patch set 2 V +1 09/13/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65647

  5. Andreas Kienast commented on patch set 2 09/13/24, 10:05

    For whatever reason, `readonly` doesn't have a visual effect on checkboxes.
  6. Benjamin Franzke uploaded patch set 3 V +1 09/13/24, 11:12

  7. Benjamin Franzke commented on patch set 3 09/13/24, 11:12

    Reply

    good catch, fixed via `disabled` – https://stackoverflow.com/a/12971018
  8. core-ci voted on patch set 3 V +1 09/13/24, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65667

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 09/16/24, 10:04

  10. Benjamin Franzke rebased onto patch set 4 CR +1 V +1 09/16/24, 12:37

  11. core-ci voted on patch set 4 V +1 09/16/24, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65884

  12. Andreas Kienast voted on patch set 4 CR +1 V +1 09/16/24, 13:00

  13. Sebastian Iffland voted on patch set 4 CR +1 09/16/24, 14:47

  14. Frank Nägler voted on patch set 4 CR +1 09/16/24, 15:02

  15. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/16/24, 15:06

  16. Benjamin Franzke voted on patch set 4 CR +2 V +2 09/16/24, 15:21

  17. Benjamin Franzke merged patch set 5 09/16/24, 15:21