Review main Merged

86032[FEATURE] Auto-discover record preview templates

Oli Bartsch CR +2 V +2 Hard +451 −127 updated 09/16/24, 15:55

Commit message

A new generic way of defining record preview template
paths is introduced. Corresponding TSconfig syntax:

    `record.preview.<table_name>.paths`

Using this option to define template paths, the
templates for the record previews as well as
related layouts and partials are auto-discovered.

Those templates receive the fully transformed record
object.

The functionality is first used for content element
previews in the page module but will be used in
other areas of the backend in the future.

Therefore, the corresponding service has been
renamed to `FluidBasedRecordPreviewRenderer`,
while the event listener method for the content
preview got the speaking name `renderPageContentPreview`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1116

  1. Oli Bartsch uploaded patch set 1 09/11/24, 21:04

  2. core-ci voted on patch set 1 V +1 09/11/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65497

  3. Oli Bartsch uploaded patch set 2 V +1 09/12/24, 10:42

  4. core-ci voted on patch set 2 V +1 09/12/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65557

  5. Oli Bartsch uploaded patch set 3 V +1 09/12/24, 13:02

  6. core-ci voted on patch set 3 V +1 09/12/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65562

  7. Oli Bartsch uploaded patch set 4 V +1 09/12/24, 13:40

  8. Oli Bartsch uploaded patch set 5 09/12/24, 13:42

  9. core-ci voted on patch set 5 V -1 09/12/24, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65571

  10. core-ci voted on patch set 5 V +1 09/12/24, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65571

  11. Benni Mack voted on patch set 5 CR +1 09/12/24, 15:44

  12. Jochen Roth voted on patch set 5 CR +1 V +1 09/12/24, 16:11

  13. Benni Mack voted on patch set 5 V +1 09/12/24, 16:38

  14. Oli Bartsch voted on patch set 5 CR +2 V +2 09/12/24, 16:41

  15. Oli Bartsch merged patch set 6 09/12/24, 16:41

  16. Christian Kuhn wrote 09/16/24, 15:55

    Created a revert of this change as I2d1e7eda2c1edfcce910b7ed2f5835508d4a26e4