Review main Merged

86035[FEATURE] Option to skip URL processing in AssetRenderer

Simon Praetorius CR +2 V +2 Normal +67 −2 updated 09/12/24, 09:01

Commit message

A new option `external` is added to the `AssetCollector` API,
which prompts `AssetRenderer` to skip any processing of the
supplied asset URI.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Simon Praetorius uploaded patch set 1 09/11/24, 21:23

  2. core-ci voted on patch set 1 V +1 09/11/24, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65500

  3. Simon Praetorius uploaded patch set 2 V +1 09/11/24, 21:46

  4. core-ci voted on patch set 2 V +1 09/11/24, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65501

  5. Oliver Hader voted on patch set 2 CR +1 09/12/24, 08:34

  6. Benni Mack voted on patch set 2 CR +1 09/12/24, 08:35

  7. Benni Mack voted on patch set 2 V +1 09/12/24, 08:53

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 09/12/24, 09:01

  9. Stefan Bürk merged patch set 3 09/12/24, 09:01