86036[!!!][FEATURE] Add TypolinkBuilderInterface with automatic DI
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106405-TypolinkBuilderSignatureChanges.rst2new+111 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-106405-AbstractTypolinkBuilder-build.rst6new+106 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106405-TypolinkBuilderInterface.rstnew+91 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+6 −6
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php2+54 −94
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+31 −24
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.php+18 −11
- typo3/sysext/frontend/Classes/Typolink/ExternalUrlLinkBuilder.php+12 −6
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.php+12 −6
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.php+9 −8
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php2+30 −15
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php3+103 −56
- typo3/sysext/frontend/Classes/Typolink/TelephoneLinkBuilder.php+5 −3
- typo3/sysext/frontend/Classes/Typolink/TypolinkBuilderInterface.phpnew+37 −0
- typo3/sysext/frontend/Configuration/Services.yaml+5 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+9 −9
- typo3/sysext/frontend/Tests/Unit/Typolink/Fixtures/AbstractTypolinkBuilderFixture.php+6 −4
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+12 −14
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+12 −8
- typo3/sysext/frontend/Tests/Unit/Typolink/EmailLinkBuilderTest.php+7 −23
Show 4 more files
Review log 3661
Show 2036 earlier messages
-
Benni Mack uploaded patch set 1 09/11/24, 21:57
-
core-ci voted on patch set 1 V -1 09/11/24, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65503
-
Benni Mack uploaded patch set 2
V -109/12/24, 08:04 -
core-ci voted on patch set 2 V -1 09/12/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65534
-
core-ci commented on patch set 2 09/12/24, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65534
-
Benni Mack uploaded patch set 3
V -109/12/24, 08:44 -
core-ci voted on patch set 3 V -1 09/12/24, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65544
-
Benni Mack uploaded patch set 4
V -109/12/24, 10:08 -
core-ci voted on patch set 4 V -1 09/12/24, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65551
-
Benni Mack marked it work in progress 01/22/25, 11:50
-
Benni Mack rebased onto patch set 5
V -103/10/25, 14:52 -
core-ci voted on patch set 5 V -1 03/10/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75422
-
Benni Mack rebased onto patch set 6
V -103/19/25, 16:03 -
core-ci voted on patch set 6 V -1 03/19/25, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75847
-
Benni Mack uploaded patch set 7
V -103/20/25, 13:22 -
core-ci voted on patch set 7 V +1 03/20/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75893
-
Benni Mack uploaded patch set 8
V +103/20/25, 21:39 -
core-ci voted on patch set 8 V -1 03/20/25, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75913
-
Benni Mack updated the commit message in patch set 9
V -103/21/25, 08:21 -
core-ci voted on patch set 9 V -1 03/21/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75947
-
Benni Mack uploaded patch set 10
V -103/21/25, 08:39 -
core-ci voted on patch set 10 V +1 03/21/25, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75948
-
Benni Mack uploaded patch set 11
V +103/22/25, 20:37 -
Benni Mack marked it ready for review 03/22/25, 20:39
-
core-ci voted on patch set 11 V +1 03/22/25, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76045
-
Garvin Hicking commented on patch set 11 03/23/25, 09:03
Deprecation-106405-AbstractTypolinkBuilder-build.rst:49```suggestion If extension authors have created custom classes extended from AbstractLinkBuilder, ```Deprecation-106405-AbstractTypolinkBuilder-build.rst:50```suggestion it is recommended to implement the new Interface, so the deprecation message ``` -
Benni Mack uploaded patch set 12
V +103/23/25, 10:44 -
Benni Mack commented on patch set 11 03/23/25, 10:44
Deprecation-106405-AbstractTypolinkBuilder-build.rst:47ReplyDoneDeprecation-106405-AbstractTypolinkBuilder-build.rst:49ReplyDoneDeprecation-106405-AbstractTypolinkBuilder-build.rst:50ReplyDone -
core-ci voted on patch set 12 V +1 03/23/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76065
-
Simon Schaufelberger voted on patch set 12 CR +1 03/23/25, 19:22
-
Benni Mack rebased onto patch set 13
CR +1V +103/27/25, 14:00 -
core-ci voted on patch set 13 V +1 03/27/25, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76464
-
Benni Mack rebased onto patch set 14
V +107/25/25, 19:35 -
core-ci voted on patch set 14 V +1 07/25/25, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82333
-
Benni Mack rebased onto patch set 15
V +108/14/25, 09:44 -
core-ci voted on patch set 15 V +1 08/14/25, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83369
-
Benni Mack uploaded patch set 16
V +109/01/25, 17:18 -
core-ci voted on patch set 16 V -1 09/01/25, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84180
-
Benni Mack uploaded patch set 17
V -109/01/25, 18:23 -
core-ci voted on patch set 17 V -1 09/01/25, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84182
-
Benni Mack uploaded patch set 18
V -109/01/25, 19:42 -
core-ci voted on patch set 18 V -1 09/01/25, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84186
-
Benni Mack uploaded patch set 19
V -109/01/25, 20:04 -
core-ci voted on patch set 19 V +1 09/01/25, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84188
-
Benni Mack uploaded patch set 20
V +109/01/25, 20:35 -
core-ci voted on patch set 20 V +1 09/01/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84190
-
Benni Mack rebased onto patch set 21
V +109/02/25, 09:19 -
Stefan Bürk commented on patch set 20 09/02/25, 09:20
AbstractTypolinkBuilder.php:30Not directly passed, only within the passed ServerRequestInterface - or am I wrong ?LinkFactory.php:156`AbstractTypolinkBuilder->_build()` checks for `buildLink()` method avoiding the deprecation there, which I'd say would be a path for extension developers to provide dual core version support and what is tried to provide as layer. This deprecation here still does not allow to make a dual core version compat without deprecations .. at least not with the "thought" mitigation provided by core and extension developers wanting a deprecation free dual core version support requires quite extensive class and class_alias shizzling just to avoid this deprecation here. Intented ? Or should we triger this only if no `buildLink()` method exists ? ``` // For people already migrating in v13, adding the method but not the // interface, this works as well :) if (method_exists($this, 'buildLink')) { return $this->buildLink($linkDetails, $conf, $request, $linkText); } ```PageLinkBuilder.php:81No implicit handing in case `currentContentObject` is not set in the request. Should we guard that and throw a concrete/runTime exception with a meaningfull message ? Secondly, do we really need to reintroduce the $contentObjectRnder property here (deprecated in AbstractTypolinkBuilder) ? I guess passing it arround would be a more better approach ... or is this planned as a after/followup ? -
core-ci voted on patch set 21 V +1 09/02/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84224
-
Benni Mack uploaded patch set 22
V +109/02/25, 09:57 -
Benni Mack commented on patch set 21 09/02/25, 09:58
AbstractTypolinkBuilder.php:30ReplyFixedLinkFactory.php:156ReplyI changed this nowPageLinkBuilder.php:81ReplyI added a fallback now. For the time being, we need cObj due to excessive use of stdWrap. This can be thinned out more and more, but as this patch has been stuck for almost a year, and I do not want to make this change even bigger again, I think this can be handled separately. -
core-ci voted on patch set 22 V +1 09/02/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84228
-
Stefan Bürk commented on patch set 22 09/02/25, 11:15
Breaking-106405-TypolinkBuilderSignatureChanges.rst:111`FullyScanned` .. cannot see any extension scanner additions in this change, do I miss something ?PageLinkBuilder.php:81ReplyThinking the same. Ack on reworking int within the smaller/internal scope lateron. -
Benni Mack commented on patch set 23
V +109/02/25, 12:00Published edit on patch set 22. -
Benni Mack commented on patch set 24 09/02/25, 12:00
Published edit on patch set 23. -
Benni Mack commented on patch set 24 09/02/25, 12:00
Breaking-106405-TypolinkBuilderSignatureChanges.rst:111ReplyDone -
core-ci voted on patch set 24 V +1 09/02/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84243
-
core-ci voted on patch set 23 V +1 09/02/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84242
-
Stefan Bürk voted on patch set 24 CR +1 V +1 09/02/25, 13:45
-
Georg Ringer voted on patch set 24 CR +2 V +2 09/02/25, 13:53
-
Georg Ringer merged patch set 25 09/02/25, 13:53
Deprecation-106405-AbstractTypolinkBuilder-build.rst:47