86040[DOCS] Add screenshots and descriptions for site settings editor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 21
- typo3/sysext/felogin/Documentation/Configuration/SettingsEditor.rst4new+31 −0
- typo3/sysext/felogin/Documentation/Configuration/SiteSets.rst+2 −0
- typo3/sysext/felogin/Documentation/Images/SettingsEditor.pngnewbinary
- typo3/sysext/felogin/Documentation/UsersManual/Index.rst+2 −1
- typo3/sysext/fluid_styled_content/Documentation/Configuration/ConstantEditor/Index.rst4+4 −0
- typo3/sysext/fluid_styled_content/Documentation/Configuration/Sets/FluidStyledContent.rst+2 −0
- typo3/sysext/fluid_styled_content/Documentation/Configuration/Sets/Index.rst+2 −0
- typo3/sysext/fluid_styled_content/Documentation/Configuration/SettingsEditor/Index.rst2new+30 −0
- typo3/sysext/fluid_styled_content/Documentation/Configuration/Index.rst+1 −0
- typo3/sysext/fluid_styled_content/Documentation/FirstSteps/SiteSets.rst+7 −0
- typo3/sysext/fluid_styled_content/Documentation/Images/ManualScreenshots/Settings.pngnewbinary
- typo3/sysext/indexed_search/Documentation/Configuration/FluidTemplating/Index.rst+2 −0
- typo3/sysext/indexed_search/Documentation/Configuration/SettingsEditor/Index.rstnew+30 −0
- typo3/sysext/indexed_search/Documentation/Configuration/SiteSet/Index.rst+2 −0
- typo3/sysext/indexed_search/Documentation/Configuration/TypoScript/Index.rst+6 −0
- typo3/sysext/indexed_search/Documentation/Configuration/Index.rst+1 −0
- typo3/sysext/indexed_search/Documentation/Images/SiteSettings.pngnewbinary
- typo3/sysext/seo/Documentation/Configuration/Index.rst+2 −0
- typo3/sysext/seo/Documentation/Configuration/Settings.rst+3 −1
- typo3/sysext/seo/Documentation/Configuration/SettingsEditor.rst2new+30 −0
Show 1 more file
Review log 2532
Show 57 earlier messages
-
Lina Wolf uploaded patch set 1 09/12/24, 06:02
-
core-ci voted on patch set 1 V +1 09/12/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65527
-
Christopher Dieterle voted on patch set 1 CR +1 09/12/24, 06:20
-
Garvin Hicking updated the commit message in patch set 2
CR +1V +109/23/24, 07:37 -
Garvin Hicking updated the commit message in patch set 3 09/23/24, 07:37
-
core-ci voted on patch set 2 V +1 09/23/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66415
-
Garvin Hicking commented on patch set 3 09/23/24, 07:43
Thanks, looking good, made a few notes for me (can't edit, on mobile atm)SettingsEditor.rst:13s/was/is/Index.rst:16s/used/used, /Index.rst:17Move this "then" earlier
-
core-ci voted on patch set 3 V +1 09/23/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66416
-
Lina Wolf commented on patch set 4
V +109/23/24, 08:36Published edit on patch set 3. -
Lina Wolf commented on patch set 4 09/23/24, 08:37
SettingsEditor.rst:13ReplyDone -
Lina Wolf commented on patch set 5 09/23/24, 08:38
Published edit on patch set 4. -
Lina Wolf commented on patch set 5 09/23/24, 08:38
Reply
DoneIndex.rst:16ReplyDoneIndex.rst:17ReplyDone -
core-ci voted on patch set 4 V +1 09/23/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66424
-
core-ci voted on patch set 5 V +1 09/23/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66425
-
Andreas Kienast commented on patch set 5 09/23/24, 09:08
If these screenshots shall be part of the official extension documentation, I'd prefer to have a neutral username (e.g. "admin"). -
Lina Wolf commented on patch set 5 09/23/24, 09:14
Reply
Feel free to replace them. It is really nothing that matters as this is only a ddev installation of the Core. -
Lina Wolf commented on patch set 5 09/23/24, 09:17
Reply
Also it is not recommended to have non-personalized admin accounts so why should we Demonstrate a bad practice here? -
Garvin Hicking uploaded patch set 6
V +109/23/24, 15:23 -
Garvin Hicking commented on patch set 6 V +1 09/23/24, 15:25
Reply
Creating screenshots is such a tedious task and it's basically outdated as soon as you make it. Maybe we can be pragmatic about it? If it's "jdoe" or "lwolf" doesn't matter too much to me, and I think Lina does have a point about non-person-bound "admin" users also has issues...? -
core-ci voted on patch set 6 V +1 09/23/24, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66447
-
Andreas Kienast commented on patch set 6 09/23/24, 17:12
Reply
never mind. I‘m in favor of top-notch screenshots as they represent our product. Since I‘m not in the docs team, I don‘t feel qualified enough to raise concerns. -
Andreas Kienast wrote 09/23/24, 17:13
Removed cc Andreas Kienast. -
Stefan Froemken commented on patch set 6 09/24/24, 12:08
SettingsEditor.rst:13I would prefer just "site set" or "site set for the frontend login" as link name.Index.rst:13remove from link name and add it behind the linkSettingsEditor.rst:13I would move that behind the link -
Lina Wolf commented on patch set 7
V +109/24/24, 12:11Published edit on patch set 6. -
Lina Wolf commented on patch set 7 09/24/24, 12:11
SettingsEditor.rst:13ReplyDoneIndex.rst:13ReplyDoneSettingsEditor.rst:13ReplyDone -
Stefan Froemken voted on patch set 7 CR +1 09/24/24, 12:19
-
core-ci voted on patch set 7 V +1 09/24/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66493
-
Stefan Froemken voted on patch set 7 V +1 09/24/24, 12:36
-
Lina Wolf abandoned the change 09/26/24, 10:01
-
Lina Wolf restored the change 09/27/24, 04:18
-
Lina Wolf marked it work in progress 09/27/24, 04:18
-
Garvin Hicking abandoned the change 11/18/24, 07:30
we need to solve the topic of screenshots first