Review main Abandoned

86040[DOCS] Add screenshots and descriptions for site settings editor

Lina Wolf CR 0 V 0 Normal +157 −2 updated 11/18/24, 07:30

Commit message

Document the site settings editor in all system
extension manuals that offer site sets.

* felogin
* fluid_styled_content
* indexed_search
* seo

While system extension EXT:form has a site set, that site set
offers no settings yet and therefore will not appear in the
settings editor.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 21

Show 1 more file

Review log 2532

Show 57 earlier messages
  1. Lina Wolf uploaded patch set 1 09/12/24, 06:02

  2. core-ci voted on patch set 1 V +1 09/12/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65527

  3. Christopher Dieterle voted on patch set 1 CR +1 09/12/24, 06:20

  4. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 09/23/24, 07:37

  5. Garvin Hicking updated the commit message in patch set 3 09/23/24, 07:37

  6. core-ci voted on patch set 2 V +1 09/23/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66415

  7. Garvin Hicking commented on patch set 3 09/23/24, 07:43

    Thanks, looking good, made a few notes for me (can't edit, on mobile atm)

    SettingsEditor.rst:13

    s/was/is/

    Index.rst:16

    s/used/used, /

    Index.rst:17

    Move this "then" earlier
  1. core-ci voted on patch set 3 V +1 09/23/24, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66416

  2. Lina Wolf commented on patch set 4 V +1 09/23/24, 08:36

    Published edit on patch set 3.
  3. Lina Wolf commented on patch set 4 09/23/24, 08:37

    SettingsEditor.rst:13 Reply

    Done
  4. Lina Wolf commented on patch set 5 09/23/24, 08:38

    Published edit on patch set 4.
  5. Lina Wolf commented on patch set 5 09/23/24, 08:38

    Reply

    Done

    Index.rst:16 Reply

    Done

    Index.rst:17 Reply

    Done
  6. core-ci voted on patch set 4 V +1 09/23/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66424

  7. core-ci voted on patch set 5 V +1 09/23/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66425

  8. Andreas Kienast commented on patch set 5 09/23/24, 09:08

    If these screenshots shall be part of the official extension documentation, I'd prefer to have a neutral username (e.g. "admin").
  9. Lina Wolf commented on patch set 5 09/23/24, 09:14

    Reply

    Feel free to replace them. It is really nothing that matters as this is only a ddev installation of the Core.
  10. Lina Wolf commented on patch set 5 09/23/24, 09:17

    Reply

    Also it is not recommended to have non-personalized admin accounts so why should we Demonstrate a bad practice here?
  11. Garvin Hicking uploaded patch set 6 V +1 09/23/24, 15:23

  12. Garvin Hicking commented on patch set 6 V +1 09/23/24, 15:25

    Reply

    Creating screenshots is such a tedious task and it's basically outdated as soon as you make it. Maybe we can be pragmatic about it? If it's "jdoe" or "lwolf" doesn't matter too much to me, and I think Lina does have a point about non-person-bound "admin" users also has issues...?
  13. core-ci voted on patch set 6 V +1 09/23/24, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66447

  14. Andreas Kienast commented on patch set 6 09/23/24, 17:12

    Reply

    never mind. I‘m in favor of top-notch screenshots as they represent our product. Since I‘m not in the docs team, I don‘t feel qualified enough to raise concerns.
  15. Andreas Kienast wrote 09/23/24, 17:13

    Removed cc Andreas Kienast.
  16. Stefan Froemken commented on patch set 6 09/24/24, 12:08

    SettingsEditor.rst:13

    I would prefer just "site set" or "site set for the frontend login" as link name.

    Index.rst:13

    remove from link name and add it behind the link

    SettingsEditor.rst:13

    I would move that behind the link
  17. Lina Wolf commented on patch set 7 V +1 09/24/24, 12:11

    Published edit on patch set 6.
  18. Lina Wolf commented on patch set 7 09/24/24, 12:11

    SettingsEditor.rst:13 Reply

    Done

    Index.rst:13 Reply

    Done

    SettingsEditor.rst:13 Reply

    Done
  19. Stefan Froemken voted on patch set 7 CR +1 09/24/24, 12:19

  20. core-ci voted on patch set 7 V +1 09/24/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66493

  21. Stefan Froemken voted on patch set 7 V +1 09/24/24, 12:36

  22. Lina Wolf abandoned the change 09/26/24, 10:01

  23. Lina Wolf restored the change 09/27/24, 04:18

  24. Lina Wolf marked it work in progress 09/27/24, 04:18

  25. Garvin Hicking abandoned the change 11/18/24, 07:30

    we need to solve the topic of screenshots first