Review main Merged

86043[TASK] Consider subtype definition for sub schemata

Oli Bartsch CR +2 V +2 Normal +239 −6 updated 09/12/24, 09:57

Commit message

In case a sub schema, e.g. `tt_content.list` makes
use of the "subtypes" feature by defining the
"subtype_value_field", corresponding configuration
("subtypes_addlist" and "subtypes_excludelist") is
now evaluated in the TCA schema and added as further
schema (third level) to the corresponding sub
schema (second level).

This will therefore look like the following:

Schema "tt_content"
    -> Sub Schema "list"
        -> Subtype Schema "tx_blog_pi1"

Via the "subtypes" feature it's only
possible to add or remove existing fields
from the corresponding sub schema.

Also note that the subtype schemata can only
be accessed using the getSubSchema() and
getSubSchemata() methods on a sub schema.
This means calling `$schemaFactory->getSchema('tt_content.list.tx_blog_pi1')`
does not work intentionally!

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1014

  1. Oli Bartsch uploaded patch set 1 09/12/24, 08:04

  2. core-ci voted on patch set 1 V +1 09/12/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65535

  3. Oli Bartsch rebased onto patch set 2 V +1 09/12/24, 08:24

  4. Oli Bartsch uploaded patch set 3 09/12/24, 08:25

  5. core-ci voted on patch set 3 V +1 09/12/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65541

  6. Oli Bartsch uploaded patch set 4 V +1 09/12/24, 08:53

  7. core-ci voted on patch set 4 V -1 09/12/24, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65547

  8. core-ci voted on patch set 4 V +1 09/12/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65547

  9. Frank Nägler voted on patch set 4 CR +1 09/12/24, 09:08

  10. Frank Nägler voted on patch set 4 V +1 09/12/24, 09:11

  11. Jochen Roth voted on patch set 4 CR +1 V +1 09/12/24, 09:12

  12. Benni Mack voted on patch set 4 CR +1 V +1 09/12/24, 09:57

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 09/12/24, 09:57

  14. Oli Bartsch merged patch set 5 09/12/24, 09:57