Review main Merged

86046[TASK] Show hint if recycler didn't find records

Andreas Kienast CR +2 V +2 Easy +23 −5 updated 10/09/24, 11:57

Commit message

The recycler backend module now shows an actual hint that no record were
found instead of showing an empty table.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2024

  1. Andreas Kienast uploaded patch set 1 09/12/24, 12:35

  2. core-ci voted on patch set 1 V +1 09/12/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65559

  3. Riccardo De Contardi commented on patch set 1 09/12/24, 12:47

    A bit perplexed about the term "recyclable". See comment

    locallang.xlf:109

    Maybe it's just a nitpick from me: I am a bit perplexed about the term "recyclable". What does it mean in this context? Could it be better to say "No deleted element have been found with the current filter"? or even "No element found with the current filter"? (isn't the context already clear?)
  4. Andreas Kienast commented on patch set 1 09/12/24, 12:50

    locallang.xlf:109 Reply

    Since the extension is called EXT:recycler and the module is named "Recycler", I assumed this label is self-explanatory. I'll change it nevertheless as I see the potential for misunderstanding.
  5. Andreas Kienast uploaded patch set 2 V +1 09/12/24, 12:50

  6. core-ci voted on patch set 2 V +1 09/12/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65561

  7. Andreas Kienast commented on patch set 2 09/12/24, 13:10

    locallang.xlf:109 Reply

    Done
  8. Guido Schmechel voted on patch set 2 CR +1 V +1 10/03/24, 10:54

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/07/24, 19:57

  10. Oli Bartsch commented on patch set 2 10/08/24, 07:58

    locallang.xlf:109

    "records" to stick to the naming.

    locallang.xlf:109

    I suggest to only add this in case a filter is actually applied. Otherwise this might lead to confusion.
  11. Andreas Kienast commented on patch set 2 10/08/24, 08:00

    locallang.xlf:109 Reply

    Acknowledged

    locallang.xlf:109 Reply

    Acknowledged
  12. Andreas Kienast commented on patch set 2 CR -1 10/08/24, 08:01

    Notification may stack...
  13. Andreas Kienast uploaded patch set 3 CR +1 V +1 10/08/24, 08:03

  14. Andreas Kienast commented on patch set 3 10/08/24, 08:07

    Reply

    Done
  15. core-ci voted on patch set 3 V +1 10/08/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67337

  16. Oli Bartsch commented on patch set 3 10/08/24, 08:29

    Empty table header is still shown for some time. Suggest to hide it initially.
  17. Oli Bartsch uploaded patch set 4 V +1 10/08/24, 08:29

  18. Oli Bartsch commented on patch set 4 CR +1 V +1 10/08/24, 08:29

    Reply

    Done
  19. core-ci voted on patch set 4 V +1 10/08/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67341

  20. Stefan Bürk voted on patch set 4 CR +1 V +1 10/09/24, 10:15

  21. Stefan Bürk voted on patch set 4 V -1 10/09/24, 10:30

  22. Stefan Bürk voted on patch set 4 V +1 10/09/24, 10:30

  23. Andreas Kienast voted on patch set 4 CR +2 V +2 10/09/24, 11:57

  24. Andreas Kienast merged patch set 5 10/09/24, 11:57