86046[TASK] Show hint if recycler didn't find records
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2024
-
Andreas Kienast uploaded patch set 1 09/12/24, 12:35
-
core-ci voted on patch set 1 V +1 09/12/24, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65559
-
Riccardo De Contardi commented on patch set 1 09/12/24, 12:47
A bit perplexed about the term "recyclable". See commentlocallang.xlf:109Maybe it's just a nitpick from me: I am a bit perplexed about the term "recyclable". What does it mean in this context? Could it be better to say "No deleted element have been found with the current filter"? or even "No element found with the current filter"? (isn't the context already clear?) -
Andreas Kienast commented on patch set 1 09/12/24, 12:50
locallang.xlf:109ReplySince the extension is called EXT:recycler and the module is named "Recycler", I assumed this label is self-explanatory. I'll change it nevertheless as I see the potential for misunderstanding. -
Andreas Kienast uploaded patch set 2
V +109/12/24, 12:50 -
core-ci voted on patch set 2 V +1 09/12/24, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65561
-
Andreas Kienast commented on patch set 2 09/12/24, 13:10
locallang.xlf:109ReplyDone -
Guido Schmechel voted on patch set 2 CR +1 V +1 10/03/24, 10:54
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/07/24, 19:57
-
Oli Bartsch commented on patch set 2 10/08/24, 07:58
locallang.xlf:109"records" to stick to the naming.locallang.xlf:109I suggest to only add this in case a filter is actually applied. Otherwise this might lead to confusion. -
Andreas Kienast commented on patch set 2 10/08/24, 08:00
locallang.xlf:109ReplyAcknowledgedlocallang.xlf:109ReplyAcknowledged -
Andreas Kienast commented on patch set 2 CR -1 10/08/24, 08:01
Notification may stack... -
Andreas Kienast uploaded patch set 3
CR +1V +110/08/24, 08:03 -
Andreas Kienast commented on patch set 3 10/08/24, 08:07
Reply
Done -
core-ci voted on patch set 3 V +1 10/08/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67337
-
Oli Bartsch commented on patch set 3 10/08/24, 08:29
Empty table header is still shown for some time. Suggest to hide it initially. -
Oli Bartsch uploaded patch set 4
V +110/08/24, 08:29 -
Oli Bartsch commented on patch set 4 CR +1 V +1 10/08/24, 08:29
Reply
Done -
core-ci voted on patch set 4 V +1 10/08/24, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67341
-
Stefan Bürk voted on patch set 4 CR +1 V +1 10/09/24, 10:15
-
Stefan Bürk voted on patch set 4 V -1 10/09/24, 10:30
-
Stefan Bürk voted on patch set 4 V +1 10/09/24, 10:30
-
Andreas Kienast voted on patch set 4 CR +2 V +2 10/09/24, 11:57
-
Andreas Kienast merged patch set 5 10/09/24, 11:57