Review main Merged

86048[BUGFIX] Call `f:count()` in Site Settings overview correctly

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 09/12/24, 19:26

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 09/12/24, 13:46

  2. Benjamin Franzke voted on patch set 1 CR +1 V +1 09/12/24, 13:49

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 09/12/24, 13:58

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/12/24, 13:58

  5. core-ci voted on patch set 1 V +1 09/12/24, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65572

  6. Oli Bartsch commented on patch set 1 09/12/24, 14:01

    Should we add an acceptance test to ensure the infobox is displayed on empty sites?
  7. Benjamin Franzke commented on patch set 1 CR +2 V +2 09/12/24, 19:25

    Reply

    That's a great idea. Will do in a `[FOLLOWUP]`!
  8. Benjamin Franzke merged patch set 2 09/12/24, 19:26