Review main Merged

86049[TASK] Add styleguide test for type=color required field

Garvin Hicking CR +2 V +2 Easy +9 −0 updated 09/15/24, 11:23

Commit message

This is needed to showcase the bug reported in
issue #104940: A required type=color field
cannot be saved/verified.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Garvin Hicking uploaded patch set 1 09/12/24, 14:22

  2. Garvin Hicking commented on patch set 1 09/12/24, 14:23

    @a.fernandez@scripting-base.de if you have the time after FF maybe you can check thie related bug out. Too much JS magic involved for me to get through easily :D This patch should help to reproduce.
  3. core-ci voted on patch set 1 V +1 09/12/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65578

  4. Anja Leichsenring commented on patch set 1 CR +1 V +1 09/14/24, 07:59

    only adds the field to table, save not possible. All correct for the scope of the patch.
  5. Guido Schmechel voted on patch set 1 CR +1 V +1 09/15/24, 10:52

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 09/15/24, 11:23

  7. Anja Leichsenring merged patch set 2 09/15/24, 11:23