Review main Merged

86051[TASK] Hide "auto" color scheme option in dropdown

Andreas Nedbal CR +2 V +2 Easy +4 −0 updated 09/15/24, 08:56

Commit message

The usability of a "OS default" option isn't the greatest.
Depending on the active color scheme, the "auto" option doesn't
change anything visually. Having the imminent result options left
in the dropdown is better. The "OS default" (auto) option is still
provided in the User Settings and as default when the feature is
initially enabled (and no setting was saved by the user).

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Nedbal uploaded patch set 1 09/12/24, 15:07

  2. core-ci voted on patch set 1 V +1 09/12/24, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65587

  3. Andreas Kienast commented on patch set 1 09/12/24, 19:51

    can you please provide a reasoning in the commit message?
  4. Andreas Nedbal updated the commit message in patch set 2 V +1 09/13/24, 07:11

  5. Andreas Nedbal commented on patch set 2 09/13/24, 07:11

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/13/24, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65631

  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/13/24, 07:31

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 09/15/24, 00:28

  9. Andreas Nedbal voted on patch set 2 CR +2 V +2 09/15/24, 08:56

  10. Andreas Nedbal merged patch set 3 09/15/24, 08:56