Review main Merged

86074[BUGFIX] Prevent infinite site settings cache recreation

Benjamin Franzke CR +2 V +2 Easy +3 −2 updated 09/12/24, 21:53

Commit message

Site settings rely on the Settings base class __set_state() method
to recreate the object from cache.
Since the base class used `new self` instead of `new static`,
the object received an invalid type and was therefore ignored.

Use `new static` to ensure the correct constructor is invoked.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Benjamin Franzke uploaded patch set 1 09/12/24, 21:14

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 09/12/24, 21:20

  3. core-ci voted on patch set 1 V +1 09/12/24, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65605

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 09/12/24, 21:40

  5. Oliver Hader voted on patch set 2 CR +2 V +2 09/12/24, 21:43

  6. Oliver Hader voted on patch set 2 CR +1 V +1 09/12/24, 21:43

  7. Garvin Hicking voted on patch set 2 CR +1 V +1 09/12/24, 21:43

  8. core-ci voted on patch set 2 V +1 09/12/24, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65609

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/12/24, 21:53

  10. Benjamin Franzke merged patch set 3 09/12/24, 21:53