Review main Merged

86075[BUGFIX] Load cached TcaSchema in regular Bootstrap

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/13/24, 07:18

Commit message

Drop the `$force` parameter, which is intended to create a fresh
(ignoring existing cache) instance everytime. This parameter
was probably forgotten during development.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Benjamin Franzke uploaded patch set 1 09/12/24, 21:26

  2. core-ci voted on patch set 1 V +1 09/12/24, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65606

  3. Nikita Hovratov commented on patch set 1 CR +1 V +1 09/12/24, 22:00

    I think this was my mistake, because I tempered with the Schema at early bootstrap and modified the state. Then added the force true to get a clean instance. But this is not important anymore.
  4. Nikita Hovratov updated the commit message in patch set 2 CR +1 V +1 09/12/24, 22:01

  5. Nikita Hovratov voted on patch set 2 CR +1 V +1 09/12/24, 22:01

  6. core-ci voted on patch set 2 V +1 09/12/24, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65611

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 09/13/24, 07:18

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/13/24, 07:18

  9. Benjamin Franzke merged patch set 3 09/13/24, 07:18