Review main Merged

86076[BUGFIX] Migrate wizard groups position common to default

Nikita Hovratov CR +2 V +2 Easy +14 −0 updated 10/08/24, 13:01

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1112

  1. Nikita Hovratov uploaded patch set 1 09/12/24, 21:55

  2. core-ci voted on patch set 1 V +1 09/12/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65610

  3. Lina Wolf commented on patch set 1 CR +1 09/13/24, 10:44

    Looks good to me but did not have time to test yet
  4. Lina Wolf commented on patch set 1 V +1 09/14/24, 04:02

    Tested it and works fine: common from page tsconfig is migrated to default group
  5. Nikita Hovratov commented on patch set 1 09/27/24, 10:21

    bump
  6. Garvin Hicking commented on patch set 1 09/27/24, 17:02

    Could you provide more insight on what this does in either the commit message or the issue?
  7. Nikita Hovratov commented on patch set 1 09/28/24, 12:40

    Reply

    I was hoping this patch was small enough to be sufficient without a lengthy description :D The context is: As the NewContentElementWizard items are now registered automatically by TCA, the standard group is no more called "common" but "default". This is already migrated in the main feature patch. But we forgot to migrate the positional options before/after as well. So old definitions won't be placed correctly.
  8. Garvin Hicking commented on patch set 1 CR +1 V +1 09/30/24, 09:17

    Sorry Nikkita; that helped. I was standing on a schlauch. ;-)
  9. Guido Schmechel commented on patch set 1 CR +1 V +1 10/02/24, 22:45

    Basically does what it should. And that's why the +1. Perhaps a little too late: But doesn't it make sense to use a class variable or a class constant for ‘common’? Sounds like a fairly static variable to me. Especially because the classes have several hits. (But should not block this patch)
  10. Nikita Hovratov commented on patch set 1 10/08/24, 12:59

    bump
  11. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/08/24, 13:00

  12. Benjamin Franzke merged patch set 2 10/08/24, 13:01