Review main Merged

86081[TASK] Harden site settings save action

Benjamin Franzke CR +2 V +2 Easy +24 −9 updated 09/13/24, 09:37

Commit message

Apply an additional form token (send via POST)
for the site settings save action, additionally
to the get-based route token.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 913

  1. Benjamin Franzke uploaded patch set 1 09/13/24, 07:21

  2. core-ci voted on patch set 1 V +1 09/13/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65632

  3. Andreas Kienast commented on patch set 2 V +1 09/13/24, 08:15

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 09/13/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65634

  5. Benjamin Franzke uploaded patch set 3 V +1 09/13/24, 08:27

  6. core-ci voted on patch set 3 V -1 09/13/24, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65636

  7. Benjamin Franzke uploaded patch set 4 V -1 09/13/24, 08:35

  8. core-ci voted on patch set 4 V +1 09/13/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65637

  9. Oliver Hader voted on patch set 4 CR +1 09/13/24, 09:31

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 09/13/24, 09:33

  11. Oliver Hader voted on patch set 4 V +1 09/13/24, 09:36

  12. Benjamin Franzke voted on patch set 4 CR +2 V +2 09/13/24, 09:37

  13. Benjamin Franzke merged patch set 5 09/13/24, 09:37