Review main Merged

86082[BUGFIX] Do not "prep" record title in Move Element wizard

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/17/24, 20:20

Commit message

If a content element has an empty value in its `header` field, the "Move
Element" wizard may show `<em>[No title]</em>`. This is caused by
`BU::getRecordTitle()` that receives the `prep` argument being true.

The generated output is used in Fluid which escapes the content anyway,
therefore `prep` must not be set.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jasmina Ließmann +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 09/13/24, 08:38

  2. core-ci voted on patch set 1 V +1 09/13/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65639

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 09/17/24, 19:59

  4. Jasmina Ließmann voted on patch set 1 CR +1 V +1 09/17/24, 20:14

  5. Stefan Bürk voted on patch set 1 CR +1 V +1 09/17/24, 20:17

  6. Stefan Bürk voted on patch set 1 CR +2 V +2 09/17/24, 20:20

  7. Stefan Bürk merged patch set 2 09/17/24, 20:20