86085[TASK] Add test for translation behaviour of inline children on copy
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- André Buchmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 3
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyParentContentToDiffLanguageWAllChildren.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/ActionTest.php+11 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.php+26 −0
Review log 1215
-
Astrid Haubold uploaded patch set 1 09/13/24, 09:51
-
core-ci voted on patch set 1 V -1 09/13/24, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65652
-
André Buchmann uploaded patch set 2
V -109/13/24, 10:44 -
core-ci voted on patch set 2 V +1 09/13/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65662
-
André Buchmann voted on patch set 2 CR +1 V +1 09/13/24, 11:21
-
Eric Harrer voted on patch set 2 CR +1 V +1 09/13/24, 11:25
-
Stefan Bürk commented on patch set 2 09/14/24, 01:00
I have a question - should this also be tested against workspaces and later with apply/discard thingy ? Not sure if the irre tests are already test for workspaces ... -
Christian Kuhn uploaded patch set 3
CR +1V +109/17/24, 14:57 -
Christian Kuhn commented on patch set 2 09/17/24, 14:58
added a todo stating there is a difference. removed v12 backport from list still i think *if* we change stuff in this area, it will be v13 only.Reply
i think its ok to stickt to non-ws for now and eventually increase coverage if the "why does this produce different results?" is worked on. -
Christian Kuhn voted on patch set 3 CR +1 V +1 09/17/24, 14:58
-
core-ci voted on patch set 3 V +1 09/17/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66046
-
Stefan Bürk voted on patch set 3 CR +1 V +1 09/17/24, 15:34
-
André Buchmann voted on patch set 3 CR +1 V +1 09/17/24, 16:13
-
Christian Kuhn voted on patch set 3 CR +2 V +2 09/17/24, 19:00
-
Christian Kuhn merged patch set 4 09/17/24, 19:01