86086[BUGFIX] Correct indention for list-group applied to ul or ol
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 56
-
Benjamin Kott uploaded patch set 1 09/13/24, 11:03
-
core-ci voted on patch set 1 V +1 09/13/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65666
-
Andreas Kienast voted on patch set 1 CR +1 V +1 09/13/24, 11:13
-
Benjamin Franzke commented on patch set 1 09/13/24, 11:20
Shouldn't we also unset `list-style` then? I'm asking because typo3/sysext/backend/Resources/Private/Templates/Mfa/Auth.html uses incorrect `.list-group` markup(?) `.list-group` without `.list-group-item` items. This patch wouldn't break that case – as it applies `px-lg-4` :\ – but in general the list dots would now be placed left of the vertial start. -
Benjamin Franzke voted on patch set 1 CR +2 V +2 09/13/24, 11:38
-
Benjamin Franzke merged patch set 2 09/13/24, 11:38