Review main Merged

86087[TASK] Increase size of `sys_file_metadata.publisher` database field

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 09/14/24, 09:09

Commit message

The database table `sys_file_metadata` set a limit of 45
characters for the `publisher` column (via TCA configuration), which
was not enough in some cases, for example:

  macOS Version 10.14.6 (Build 18G103) Quartz PDFContext

The character limit has now been raised to 120 characters.

The database column is not (by default) part of an index
column, and the table `sys_file_metadata` still has enough
column space available to rectify this change.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Garvin Hicking uploaded patch set 1 09/13/24, 12:29

  2. core-ci voted on patch set 1 V +1 09/13/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65674

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 09/13/24, 20:51

  4. Anja Leichsenring voted on patch set 1 CR +2 V +2 09/14/24, 09:09

  5. Anja Leichsenring merged patch set 2 09/14/24, 09:09