Review main Merged

86088[DOCS] Better document workspace permissions for file management

Garvin Hicking CR +2 V +2 Easy +14 −0 updated 09/18/24, 07:15

Commit message

To better reflect the need for fitting workspace permissions in
regard to managing files, two changes are applied with this
patch:

- The TCA section of be_users and be_groups now has a description
  for the field "workspace_perms".

- The Documentation adds a (small) section on the relevance of
  files in workspace situations.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Guido Schmechel +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1215

  1. Garvin Hicking uploaded patch set 1 09/13/24, 12:50

  2. core-ci voted on patch set 1 V +1 09/13/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65675

  3. Christian Kuhn updated the commit message in patch set 2 V +1 09/17/24, 15:06

  4. Christian Kuhn commented on patch set 2 CR +1 V +1 09/17/24, 15:07

    i would rather tend to leave out v12 at this point in time to avoid having new labels if not strictly necessary. is that fine with you, or should we still have this in v12?
  5. Garvin Hicking commented on patch set 2 09/17/24, 15:10

    Reply

    fine by me, I'd do a small 12.4 follow-up with only the ReST file update, yes?
  6. core-ci voted on patch set 2 V +1 09/17/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66050

  7. Christian Kuhn commented on patch set 2 09/17/24, 15:24

    Reply

    in this case we could keep the v12 in the releases line and simply prepare a reduced backport.
  8. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 09/17/24, 15:28

  9. core-ci voted on patch set 3 V +1 09/17/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66060

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 09/17/24, 19:36

  11. Garvin Hicking commented on patch set 3 09/18/24, 06:19

    Reply

    Ack, will do that in backport then once votes are confirmed
  12. Guido Schmechel voted on patch set 3 CR +1 V +1 09/18/24, 06:50

  13. Stefan Bürk voted on patch set 3 CR +1 V +1 09/18/24, 07:11

  14. Garvin Hicking voted on patch set 3 CR +2 V +2 09/18/24, 07:14

  15. Garvin Hicking merged patch set 4 09/18/24, 07:15