86098[WIP][TASK] Migrate `tx_cms_showpic` eID handler to middleware
Commit message
Review
-
Code review CR -2
- Stefan Bürk -2
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/Controller/ShowImageController.phpdeleted+0 −243
- typo3/sysext/frontend/Classes/Middleware/ShowImageHandler.phpnew+313 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+11 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/ShowImageHandlerTest.phprenamed+5 −2
- typo3/sysext/frontend/ext_localconf.php+0 −4
Review log 1117
-
Stefan Bürk uploaded patch set 1 09/15/24, 02:50
-
core-ci voted on patch set 1 V -1 09/15/24, 02:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65779
-
Stefan Bürk uploaded patch set 2
V -109/17/24, 10:41 -
core-ci voted on patch set 2 V -1 09/17/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65986
-
Stefan Bürk uploaded patch set 3
V -109/17/24, 13:32 -
core-ci voted on patch set 3 V -1 09/17/24, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66024
-
Stefan Bürk uploaded patch set 4
V -109/17/24, 17:25 -
core-ci voted on patch set 4 V +1 09/17/24, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66066
-
Stefan Bürk uploaded patch set 5
V +109/17/24, 18:35 -
core-ci voted on patch set 5 V +1 09/17/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66069
-
Benjamin Franzke commented on patch set 5 09/17/24, 19:55
Hm… Middlewares were not meant to replace eIDs (we would have migrated them right away, if we wanted that). Parsing kind-of random routes in middlewares doesn't scale well IMO. I think we should rather try to introduce some kind of general frontend routing. (not just site-scoped, but globally scoped) Middlewares are good for encapsulation, and also helpful to create specific routes in extensions, as TYPO3 core provides no solution – but we as TYPO3 core should actualy think about a solution IMO, and not just apply this "hack" ourselves.. -
Stefan Bürk commented on patch set 5 CR -2 09/17/24, 22:41
Reply
That makes literally sense for tx_cms_showpic and the other core eID which are designed to run early. However, a lot of developers out there simply move the EidHandler Middleware to a later point to have things like site, page or TSFE / TypoScript bootstrapped. It's scary to hear these things on camps and events. The thinking behind this change was to make it free while keeping "the" place and uri intact for now. But ack. Let's consider that in a bigger and correct concept. -
Stefan Bürk rebased onto patch set 6
V +109/19/24, 14:02Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 6 V +1 09/19/24, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66221
-
Benjamin Franzke commented on patch set 6 09/19/24, 14:44
Reply Unresolved
> However, a lot of developers out there simply move the EidHandler Middleware to a later point to have things like site, page or TSFE / TypoScript bootstrapped. It's scary to hear these things on camps and events. thanks for the info, that's good to know – something we need to consider for global routes. -
Benni Mack marked it work in progress 04/09/25, 10:18
-
Stefan Bürk abandoned the change 09/06/25, 01:38
abanding for now. Needs another approach as it seems.