Review main Merged

86101[DOCS] Improve f:debug examples

TYPO3com CR +2 V +2 Easy +5 −5 updated 09/17/24, 11:06

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. TYPO3com uploaded patch set 1 09/15/24, 04:58

  2. core-ci voted on patch set 1 V +1 09/15/24, 05:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65797

  3. Garvin Hicking commented on patch set 1 09/15/24, 09:17

    I think this is the actual output of debugging an areay. Maybe not remove it but provide a better output??
  4. Stefan Bürk commented on patch set 1 09/15/24, 11:34

    Reply

    That shows a "example" output - I guess adding some sentene to it: ``` would output the content o the variable, for example: :: foobarbaz ```
  5. Lina Wolf commented on patch set 1 09/15/24, 12:56

    If this is an output it should actually look like this:: Extbase Variable Dump 'foobarbaz' (9 chars)
  6. Lina Wolf commented on patch set 1 09/15/24, 13:00

    And if we would indeed debug an array it should look like:: Extbase Variable Dump array(1 item) foobar => 'bas' (3 chars) Just writing "foobarbaz" has no relation to the codesnippet above?
  7. Christian Kuhn uploaded patch set 2 V +1 09/17/24, 10:26

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 09/17/24, 10:26

  9. core-ci voted on patch set 2 V +1 09/17/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65982

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 09/17/24, 11:03

  11. Stefan Bürk merged patch set 3 09/17/24, 11:04

  12. Benjamin Franzke commented on patch set 3 09/17/24, 11:06

    Unresolved

    What about 12.4/11.5?
  13. Andreas Kienast commented on patch set 3 09/17/24, 11:06

    Isn't this relevant for 12.4 and 11.5 as well?