Review main Abandoned

86102[TASK] Introduce SchemaType structure object

Oli Bartsch CR 0 V 0 Normal +157 −55 updated 01/13/25, 17:26

Commit message

By implementing the TcaSchema API, the definition of
the main type (usually the table name) and the record
type (defined via the "type" ctrl option) has been done
by using a string, while separating the types by a dot.

This had some drawbacks, e.g. on fetching a possbile sub
type (see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86043),
or in case a record type has a dot in its name.

This is now resolved by using a dedicated structure
object, which implements additional funcionality
like `formString()` and `__toString()` to make
fetching and checking for schemas as easy as before.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 1222

  1. Oli Bartsch uploaded patch set 1 09/15/24, 08:00

  2. core-ci voted on patch set 1 V -1 09/15/24, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65799

  3. Oli Bartsch uploaded patch set 2 V -1 09/17/24, 14:02

  4. Oli Bartsch uploaded patch set 3 09/17/24, 14:15

  5. core-ci voted on patch set 2 V -1 09/17/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66026

  6. Oli Bartsch uploaded patch set 4 09/17/24, 14:24

  7. Oli Bartsch uploaded patch set 5 09/17/24, 14:35

  8. core-ci voted on patch set 4 V +1 09/17/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66029

  9. core-ci voted on patch set 5 V +1 09/17/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66030

  10. Oli Bartsch uploaded patch set 6 V +1 09/17/24, 17:07

  11. core-ci voted on patch set 6 V +1 09/17/24, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66064

  12. Oli Bartsch uploaded patch set 7 V +1 10/01/24, 15:07

  13. core-ci voted on patch set 7 V +1 10/01/24, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66903

  14. Oli Bartsch uploaded patch set 8 V +1 10/08/24, 09:11

  15. core-ci voted on patch set 8 V +1 10/08/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67360

  16. Oli Bartsch rebased onto patch set 9 V +1 10/20/24, 08:39

  17. Oli Bartsch updated the commit message in patch set 10 10/20/24, 08:39

  18. core-ci voted on patch set 9 V +1 10/20/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68254

  19. core-ci voted on patch set 10 V +1 10/20/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68255

  20. Oli Bartsch uploaded patch set 11 V +1 01/13/25, 16:55

  21. core-ci voted on patch set 11 V -1 01/13/25, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72371

  22. Oli Bartsch abandoned the change 01/13/25, 17:26

    Due to removal of subtypes, introducing a object is kind of over engineered. We just want to allow record types with dots, see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87721