86104[FEATURE] Introduce ContentArea
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Simon Praetorius +1
- Nikita Hovratov +1
- Matthias Vogel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Praetorius +1
- Nikita Hovratov +1
- Matthias Vogel +1
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/core/Classes/Page/ContentArea.phpnew+93 −0
- typo3/sysext/core/Classes/Page/ContentAreaClosure.phpnew+35 −0
- typo3/sysext/core/Classes/Page/ContentAreaCollection.php2new+80 −0
- typo3/sysext/core/Classes/Page/ContentAreaNotFoundException.phpnew+26 −0
- typo3/sysext/core/Classes/Page/PageLayout.php+2 −2
- typo3/sysext/core/Classes/Page/PageLayoutResolver.php2+4 −17
- typo3/sysext/core/Classes/Page/ResolveContentAreasEvent.php2new+46 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst2new+135 −0
- typo3/sysext/frontend/Classes/Content/ContentAreaResolver.php7new+106 −0
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php7+10 −1
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+4 −71
- typo3/sysext/frontend/Classes/Event/AfterContentHasBeenFetchedEvent.php2+1 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Default.fluid.html+5 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Home.fluid.html+3 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageContentProcessor/Pages/Productdetail.fluid.html3+6 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/Fixtures/PageLayouts/Productdetail.tsconfig+1 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/PageContentFetchingProcessorTest.php+2 −0
Review log 5377
Show 3452 earlier messages
-
Oli Bartsch uploaded patch set 1 09/15/24, 09:44
-
core-ci voted on patch set 1 V -1 09/15/24, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65801
-
Oli Bartsch uploaded patch set 2
V -109/15/24, 09:54 -
core-ci voted on patch set 2 V +1 09/15/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65802
-
Oli Bartsch uploaded patch set 3
V +109/15/24, 12:43 -
core-ci voted on patch set 3 V +1 09/15/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65808
-
Oli Bartsch uploaded patch set 4
V +109/16/24, 09:05 -
core-ci voted on patch set 4 V -1 09/16/24, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65863
-
Oli Bartsch uploaded patch set 5
V -109/16/24, 09:31 -
core-ci voted on patch set 5 V -1 09/16/24, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65865
-
Oli Bartsch uploaded patch set 6
V -109/16/24, 09:42 -
Oli Bartsch uploaded patch set 7 09/16/24, 09:49
-
core-ci voted on patch set 6 V +1 09/16/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65866
-
core-ci voted on patch set 7 V +1 09/16/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65867
-
Simon Praetorius commented on patch set 7 09/16/24, 11:14
Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:34keyword => property ?Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:37(where :html:`main` is the identifier, as defined in the page layout and :html:`content` is the default variable name).Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:48are => isFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:90remove "Tests" from pathFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:95To make the RST consistent, this should specify the area variable used below: <f:render partial="ContentElement" arguments="{record: record, area: content.main}" />ContentAreaResolver.php:54I think this new approach requires one SQL per content area, while the old approach required only 1+n (one for all non-slide areas combined, one for each slide area). Not sure if this is problematic. The new code is much clearer though.PageViewContentObject.php:143This is added to not be breaking I guess? Because all other variables are just reserved and don't provide a way to adjust their names.PageViewContentObject.php:150Small nitpick: If this variable is set before `page`, it will be easier for users to see the object's content when using the f:debug VH. Maybe we can adjust the order? Same for language vs. site btw. language should be defined first. -
Christian Kuhn voted on patch set 7 CR -2 09/16/24, 13:46
-
Christian Kuhn commented on patch set 7 CR 0 09/16/24, 15:44
i suggest to not get this merged 1 day before FF anymore: most of the involved code is very young and we should probably wait for proof they are working as intended before adding more on top of it. i'll not upvote the current solution. -
Benni Mack marked it work in progress 03/22/25, 12:32
-
Simon Praetorius uploaded patch set 8
V +101/23/26, 09:40 -
Simon Praetorius commented on patch set 8 01/23/26, 09:45
I've resolved the conflicts to the best of my knowledge. Noteworthy: * I'm not sure if `ContentAreaResolver` still covers everything that was removed from `PageLayoutResolver` and `PageContentFetchingProcessor`, however it worked in my (very simple) local setup * The patch breaks the existing `AfterContentHasBeenFetchedEvent` signature because of the lazy fetching using objects. I've fixed it temporarily to get the tests green. We probably could provide the array there, but then lazy would be cancelled out. * Of course, version-related stuff (deprecations...) still needs to be adjusted -
core-ci voted on patch set 8 V -1 01/23/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94144
-
Simon Praetorius uploaded patch set 9
V -101/23/26, 09:51 -
core-ci voted on patch set 9 V +1 01/23/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94146
-
Simon Praetorius commented on patch set 9 01/23/26, 12:49
AfterContentHasBeenFetchedEvent.php:29This would be a breaking change -
Oli Bartsch uploaded patch set 10
V +102/02/26, 16:25 -
Oli Bartsch commented on patch set 10 02/02/26, 16:26
This change is ready for review.Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rst:40ReplySince v13 is released, we should not update this changelog anymore.Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:34ReplyDoneFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:37ReplyDoneFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:48ReplyDoneFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:90ReplyDoneFeature-104974-ContentAreaRelatedInformationInTheFrontend.rst:95ReplyDoneContentAreaResolver.php:54ReplyI refactored the initial code intentionally to be much more intuitive. I don't think that one query per area will increase load notably.PageViewContentObject.php:143ReplyExactly current default when manually calling "page-content" is "content".PageViewContentObject.php:150ReplyIs this still relevant after the latest changes to the debugging infrastructure?AfterContentHasBeenFetchedEvent.php:29ReplyDone -
core-ci voted on patch set 10 V +1 02/02/26, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94829
-
Matthias Vogel uploaded patch set 11
V +102/02/26, 18:26 -
Matthias Vogel uploaded patch set 12 02/02/26, 18:30
-
core-ci voted on patch set 12 V +1 02/02/26, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94843
-
Matthias Vogel uploaded patch set 13
V +102/02/26, 18:43 -
Matthias Vogel voted on patch set 13 CR +1 V +1 02/02/26, 18:43
-
core-ci voted on patch set 11 V -1 02/02/26, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94842
-
core-ci voted on patch set 13 V +1 02/02/26, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94844
-
Oli Bartsch uploaded patch set 14
CR +1V +102/03/26, 08:34 -
Matthias Vogel voted on patch set 14 CR +1 V +1 02/03/26, 08:35
-
core-ci voted on patch set 14 V +1 02/03/26, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94871
-
Nikita Hovratov voted on patch set 14 CR +1 02/03/26, 09:11
-
Simon Praetorius commented on patch set 14 CR -1 02/03/26, 09:34
reviewing... -
Simon Praetorius commented on patch set 14 02/03/26, 10:07
ContentAreaCollection.php:59Looking at the deleted code, I think this is a different structure than before: before: ['colPos' => 123, ..., 'records' => [...]] after: ['area' => ContentAreaInterface, 'records' => [...]]ContentAreaInterface.php:28After a discussion with @typo3@kanti.de, I would argue that we should leave out this interface in the first step. The current interface seems to broad to me, this should be multiple interfaces in my opinion. As we can always add interfaces later and the immediate todos (e. g. using this in EXT:container) can be solved without the interface, I would skip this for now and stick to an `@internal` final class.ContentAreaResolver.php:48```suggestion // @deprecated Identifier has to be set -> throw exception in v15 ``` -
Simon Praetorius commented on patch set 14 02/03/26, 10:10
ContentAreaResolver.php:54ReplyAcknowledgedPageViewContentObject.php:150ReplyAcknowledged -
Benni Mack commented on patch set 14 02/03/26, 13:36
PageLayoutResolver.php:47should be the EventDispatcherInterfaceResolveContentAreasEvent.php:25Event in EXT:core depends on code in EXT:backend? I mean, if there is no other way, then that's it but surely not ideal.Productdetail.fluid.html:5should we rather do an implode here? -
Matthias Vogel uploaded patch set 15
CR +1V +102/03/26, 13:41 -
Matthias Vogel uploaded patch set 16 02/03/26, 13:46
-
core-ci voted on patch set 15 V -1 02/03/26, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94908
-
Matthias Vogel uploaded patch set 17 02/03/26, 13:59
-
Matthias Vogel commented on patch set 17 02/03/26, 13:59
ContentAreaCollection.php:59ReplyDoneContentAreaInterface.php:28ReplyDonePageLayoutResolver.php:47ReplyDoneContentAreaResolver.php:48ReplyDone -
Matthias Vogel uploaded patch set 18 02/03/26, 14:10
-
core-ci voted on patch set 17 V -1 02/03/26, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94913
-
Matthias Vogel commented on patch set 18 02/03/26, 14:10
ResolveContentAreasEvent.php:25Replyin PageLayoutResolver there already is a dependency on EXT:backend. To remove that dependency we would need to refactor alot of code.Productdetail.fluid.html:5ReplyDone -
core-ci voted on patch set 16 V +1 02/03/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94911
-
core-ci voted on patch set 18 V +1 02/03/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94916
-
Matthias Vogel uploaded patch set 19
V +102/03/26, 15:16 -
core-ci voted on patch set 19 V -1 02/03/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94923
-
Matthias Vogel uploaded patch set 20
V -102/03/26, 15:31 -
Matthias Vogel voted on patch set 20 CR +1 V +1 02/03/26, 16:00
-
core-ci voted on patch set 20 V -1 02/03/26, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94925
-
core-ci voted on patch set 20 V +1 02/03/26, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94925
-
Simon Praetorius voted on patch set 20 CR +1 V +1 02/03/26, 17:09
-
Oli Bartsch commented on patch set 20 02/03/26, 17:12
Productdetail.fluid.html:5ReplyI did not know the ViewHelper for this. Looks much better now. -
Nikita Hovratov commented on patch set 20 CR -1 02/03/26, 20:56
reviewing -
Nikita Hovratov uploaded patch set 21
CR +1V +102/03/26, 21:54 -
core-ci voted on patch set 21 V +1 02/03/26, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94948
-
Nikita Hovratov uploaded patch set 22
V +102/03/26, 22:05 -
Nikita Hovratov voted on patch set 22 CR +1 V +1 02/03/26, 22:06
-
core-ci voted on patch set 22 V +1 02/03/26, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94949
-
Simon Praetorius voted on patch set 22 CR +1 V +1 02/03/26, 22:14
-
Garvin Hicking commented on patch set 22 02/03/26, 22:28
(just thoughts, not forcing revotes)Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:103```suggestion Introducing :php:`ContentArea` also improves the ``` (can be done post-merge)ContentAreaResolver.php:84named arguments here?PageViewContentObject.php:168```suggestion 'No variable name ("contentAs" option) for the content areas has been defined in PAGEVIEW, and the fallback name "content" is not available because it has been manually set.', ``` -
Oli Bartsch uploaded patch set 23
CR +1V +102/04/26, 07:58 -
Oli Bartsch commented on patch set 23 02/04/26, 07:58
Feature-104974-ContentAreaRelatedInformationInTheFrontend.rst:103ReplyDoneContentAreaResolver.php:84ReplyDonePageViewContentObject.php:168ReplyDone -
Nikita Hovratov voted on patch set 23 CR +1 V +1 02/04/26, 08:05
-
core-ci voted on patch set 23 V +1 02/04/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94972
-
Matthias Vogel voted on patch set 23 CR +1 V +1 02/04/26, 08:14
-
Garvin Hicking voted on patch set 23 CR +1 02/04/26, 08:16
-
Simon Praetorius voted on patch set 23 CR +1 V +1 02/04/26, 08:18
-
Oli Bartsch voted on patch set 23 CR +2 V +2 02/04/26, 08:54
-
Oli Bartsch merged patch set 24 02/04/26, 08:54
Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rst:40