Review main Merged

86110[BUGFIX] Prevent CSP error due inline JavaScript

Frank Nägler CR +2 V +2 Easy +19 −8 updated 09/16/24, 07:21

Commit message

This patch removes inline JavaScript to prevent CSP errors,
and also remove inline stylings which are not required and useful.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1519

  1. Frank Nägler uploaded patch set 1 09/15/24, 14:16

  2. core-ci voted on patch set 1 V -1 09/15/24, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65814

  3. Frank Nägler uploaded patch set 2 V -1 09/15/24, 14:45

  4. core-ci voted on patch set 2 V +1 09/15/24, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65817

  5. Benni Mack updated the commit message in patch set 3 V +1 09/16/24, 05:09

  6. Benni Mack voted on patch set 3 CR +1 09/16/24, 05:09

  7. core-ci voted on patch set 3 V +1 09/16/24, 05:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65844

  8. Benjamin Franzke voted on patch set 3 CR +1 V +1 09/16/24, 05:59

  9. Andreas Kienast commented on patch set 3 09/16/24, 06:44

    Setup.html:12

    Just a nitpick: we don't need classes on hidden fields
  10. Andreas Kienast commented on patch set 3 09/16/24, 06:50

    What I do not like here: we replace the textarea with a hidden input field with a div just to allow marking a text, which currently doesn't work. The reason here is that `textarea:read-only` applies `pointer-events: none`, which is IMO wrong.
  11. Benjamin Franzke uploaded patch set 4 CR +1 V +1 09/16/24, 06:53

  12. Benjamin Franzke commented on patch set 4 09/16/24, 06:53

    Setup.html:12 Reply

    Done
  13. Benjamin Franzke commented on patch set 4 09/16/24, 06:55

    Reply

    ack, but that's a general issue. (which we should tackle indeed) …but a readonly textarea makes no semantic sense here, and per commit message it is removed to avoid `style="min-height: 10rem;"`
  14. core-ci voted on patch set 4 V +1 09/16/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65851

  15. Andreas Kienast commented on patch set 4 09/16/24, 07:10

  16. Benjamin Kott commented on patch set 4 09/16/24, 07:14

    Reply

    Acknowledged
  17. Benjamin Kott voted on patch set 4 CR +1 V +1 09/16/24, 07:14

  18. Andreas Kienast voted on patch set 4 CR +2 V +2 09/16/24, 07:14

  19. Andreas Kienast merged patch set 5 09/16/24, 07:21