86110[BUGFIX] Prevent CSP error due inline JavaScript
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Frank Nägler uploaded patch set 1 09/15/24, 14:16
-
core-ci voted on patch set 1 V -1 09/15/24, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65814
-
Frank Nägler uploaded patch set 2
V -109/15/24, 14:45 -
core-ci voted on patch set 2 V +1 09/15/24, 14:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65817
-
Benni Mack updated the commit message in patch set 3
V +109/16/24, 05:09 -
Benni Mack voted on patch set 3 CR +1 09/16/24, 05:09
-
core-ci voted on patch set 3 V +1 09/16/24, 05:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65844
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 09/16/24, 05:59
-
Andreas Kienast commented on patch set 3 09/16/24, 06:44
-
Andreas Kienast commented on patch set 3 09/16/24, 06:50
What I do not like here: we replace the textarea with a hidden input field with a div just to allow marking a text, which currently doesn't work. The reason here is that `textarea:read-only` applies `pointer-events: none`, which is IMO wrong. -
Benjamin Franzke uploaded patch set 4
CR +1V +109/16/24, 06:53 -
Benjamin Franzke commented on patch set 4 09/16/24, 06:53
Setup.html:12ReplyDone -
Benjamin Franzke commented on patch set 4 09/16/24, 06:55
Reply
ack, but that's a general issue. (which we should tackle indeed) …but a readonly textarea makes no semantic sense here, and per commit message it is removed to avoid `style="min-height: 10rem;"` -
core-ci voted on patch set 4 V +1 09/16/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65851
-
Andreas Kienast commented on patch set 4 09/16/24, 07:10
Reply
-
Benjamin Kott commented on patch set 4 09/16/24, 07:14
Reply
Acknowledged -
Benjamin Kott voted on patch set 4 CR +1 V +1 09/16/24, 07:14
-
Andreas Kienast voted on patch set 4 CR +2 V +2 09/16/24, 07:14
-
Andreas Kienast merged patch set 5 09/16/24, 07:21
Setup.html:12