86111[BUGFIX] Make bookmark button focusable when disabled
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1821
-
Sébastien Delcroix uploaded patch set 1 09/15/24, 18:37
-
core-ci voted on patch set 1 V +1 09/15/24, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65821
-
Ayke Halder commented on patch set 1 09/15/24, 19:28
Thanks for picking this up - it's a general point about 'disabled menu entries' which might need further elaboration/evaluation. I opened the ticket, and I'm not sure, if my proposed solution (which is implemented here) is the perfect solution. Also see https://github.com/twbs/bootstrap/issues/40564#issuecomment-2175459119_dropdown.scss:122We just need the outline here to mark the 'actively focused element'. The background can stay as-is, as the element itself still behaves like it is disabled. -
Sébastien Delcroix uploaded patch set 2
V +109/15/24, 19:56 -
Sébastien Delcroix commented on patch set 2 09/15/24, 19:56
_dropdown.scss:122ReplyDone -
core-ci voted on patch set 2 V +1 09/15/24, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65824
-
Sébastien Delcroix commented on patch set 2 09/16/24, 07:48
_dropdown.scss:118Maybe a pointer-events: none; would be better than cursor: default; -
Garvin Hicking commented on patch set 2 09/16/24, 08:00
_dropdown.scss:118ReplyDoes https://review.typo3.org/c/Packages/TYPO3.CMS/+/86115 address the same thing, but more globally? -
Sébastien Delcroix commented on patch set 2 09/16/24, 08:16
_dropdown.scss:118Reply UnresolvedThat's the one which made me think about this change ;) -
Ayke Halder commented on patch set 2 CR -1 09/16/24, 09:27
I opened the issue and I changed my opinion on the use of `aria-disabled="true"` here, as I do not have any feedback on how screenreaders other than 'ORCA' behave. Plus, while in screenreader browse-mode, `aria-disabled="true"` does only solve `tab`-navigation, but does not solve cursor-key-navigation. Also see discussion on Slack: https://typo3.slack.com/archives/C03AM9R17/p1726426097507239 ---- Maybe we could use a more general approach in this case: Current bookmark button states: * Set bookmark (active button) * Bookmark is already set (disabled button) Implement 'toggle' button instead: * Set bookmark (active button) * Remove bookmark (active button) ---- The point with `aria-disabled="true"` is, that the button is announced by screenreaders as disabled, but it is actually not disabled. So with `aria-disabled="true"` we must implement an additional JS click-handler, that stops the click action. Whereas with the `disabled`-attribute, the browser really disables the element - and even JS `click`-events are not fired anymore. -
Sébastien Delcroix commented on patch set 2 09/16/24, 09:33
Reply
On my side, I've only tested with macOS VoiceOver. The button is announced as "dimmed". Regarding the JS click-handler on this button, there's already an early return as I saw. -
Sébastien Delcroix commented on patch set 2 09/16/24, 09:37
Reply
Maybe the dropdown could also be replaced by 2 buttons, as "bookmark" is not really related to "sharing". -
Sébastien Delcroix commented on patch set 2 09/16/24, 10:35
Reply Unresolved
I'm in favor of an action 'toggle" button to set or remove bookmark. -
Sébastien Delcroix uploaded patch set 3
CR -1V +109/16/24, 10:54 -
core-ci voted on patch set 3 V +1 09/16/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65880
-
Ayke Halder commented on patch set 3 09/16/24, 12:53
_dropdown.scss:119As we might go for the toggle button solution, this is not relevant in this case anymore. But in general: **Always have either border or outline as 2-3px transparent line for 'high-contrast mode' to look properly.** See e.g. https://piccalil.li/blog/use-transparent-borders-and-outlines-to-assist-with-high-contrast-mode/ -
Sébastien Delcroix commented on patch set 3 09/16/24, 13:18
_dropdown.scss:119ReplyAcknowledged -
Sébastien Delcroix commented on patch set 3 09/17/24, 06:02
_dropdown.scss:122Reply UnresolvedOops sorry, I think I've understood the opposite of what you said and disabled the outline instead of removing the background. This is however not relevant anymore but I wanted you to know my misunderstanding. -
Benni Mack updated the commit message in patch set 4
V +110/18/24, 13:50 -
Benni Mack marked it work in progress 03/25/25, 12:52
-
Benni Mack abandoned the change 11/10/26, 11:05
already fixed with new Bookmark management, issue is already closed