Review main Merged

86114[DOCS] Use proper "Extbase" spelling in ViewHelper

TYPO3com CR +2 V +2 Easy +1 −1 updated 09/16/24, 10:36

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 814

  1. TYPO3com uploaded patch set 1 09/16/24, 05:55

  2. core-ci voted on patch set 1 V +1 09/16/24, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65845

  3. Garvin Hicking updated the commit message in patch set 2 V +1 09/16/24, 06:12

  4. Garvin Hicking updated the commit message in patch set 3 09/16/24, 06:14

  5. Garvin Hicking voted on patch set 3 CR +1 V +1 09/16/24, 06:14

  6. core-ci voted on patch set 3 V -1 09/16/24, 06:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65848

  7. core-ci voted on patch set 2 V -1 09/16/24, 06:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65847

  8. core-ci voted on patch set 2 V +1 09/16/24, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65847

  9. Mathias Brodala commented on patch set 3 09/16/24, 06:38

    Personally I'd like to see this fixed everywhere since Extbase is a "thing" which should always be spelled "Extbase", never "extbase" as it happens a lot of times.
  10. Lina Wolf commented on patch set 3 09/16/24, 06:40

    Reply

    Feel free to make a PR for other finds. This change is only about fixing the text of the newly added ViewHelper and will therefore not be backported etc.
  11. Mathias Brodala commented on patch set 3 09/16/24, 06:46

    Reply

    Well, the title of the first patchset was "Write Extbase as propper noun" which would cover all occurrences.
  12. core-ci voted on patch set 3 V +1 09/16/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65848

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 09/16/24, 10:36

  14. Christian Kuhn merged patch set 4 09/16/24, 10:36