Review main Merged

86115[BUGFIX] Allow text selection in read-only and disabled form fields

Andreas Kienast CR +2 V +2 Easy +9 −7 updated 09/17/24, 07:13

Commit message

The CSS property `pointer-events: none` is removed from
form elements to allow text selection and title attributes
in read-only fields again.

The cursor `not-allowed` is applied to disabled fields only.
as readonly fields are not considered disallowed (e.g. text
selection is fine).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 09/16/24, 07:04

  2. core-ci voted on patch set 1 V +1 09/16/24, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65854

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 09/16/24, 23:29

  4. Andreas Kienast voted on patch set 1 CR -2 09/17/24, 06:29

  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 09/17/24, 06:49

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Benjamin Franzke updated the commit message in patch set 3 CR +1 V +1 09/17/24, 06:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  7. Benjamin Kott voted on patch set 3 CR +1 V +1 09/17/24, 07:02

  8. core-ci voted on patch set 2 V +1 09/17/24, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65948

  9. core-ci voted on patch set 3 V +1 09/17/24, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65949

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 09/17/24, 07:13

  11. Andreas Kienast merged patch set 4 09/17/24, 07:13