Review main Merged

86116[DOCS] Prepare Changelog for 13.4

Lina Wolf CR +2 V +2 Easy +50 −0 updated 09/18/24, 12:28

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1416

  1. Lina Wolf uploaded patch set 1 09/16/24, 07:07

  2. core-ci voted on patch set 1 V +1 09/16/24, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65855

  3. Benjamin Franzke updated the commit message in patch set 2 V +1 09/16/24, 07:24

  4. Benjamin Franzke commented on patch set 2 CR -1 09/16/24, 07:25

    Do not merge before 13.3 is released.
    Let's move this into a comment, to not accidentally commit this line later.
  5. core-ci voted on patch set 2 V +1 09/16/24, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65859

  6. Chris Müller voted on patch set 2 CR +1 V +1 09/17/24, 11:33

  7. Benjamin Franzke voted on patch set 2 CR 0 09/17/24, 11:36

  8. Benni Mack voted on patch set 2 CR -2 09/17/24, 11:42

  9. Benjamin Franzke commented on patch set 2 09/17/24, 12:17

    Index.rst:10

    Is there a specific reason why `contents` and `toctree` use 3 space idnet, while `attention` has 4? Can we apply 4 to all?
  10. Stefan Bürk commented on patch set 2 09/17/24, 13:01

    Index.rst:10 Reply

    I asked Lina and she said it does not matter.
  11. Benni Mack voted on patch set 2 CR 0 09/17/24, 13:05

  12. Christian Kuhn commented on patch set 2 CR +2 V +2 09/17/24, 14:21

    Reply

    Done

    Index.rst:10 Reply

    afaiks, this is matter of taste and is no semantically difference. i hope its ok to merge as is.
  13. Christian Kuhn merged patch set 3 09/17/24, 14:22

  14. Benjamin Franzke commented on patch set 3 09/17/24, 19:48

    Index.rst:10 Reply

    This is unfortunate. Inconsistency in one file isn't matter of taste, its probably a copy&paste error, but not taste… Just leave it open if you're unwilling to fix it by yourself, but please don't rush things in.
  15. Garvin Hicking commented on patch set 3 09/17/24, 20:43

    Index.rst:10 Reply

    I will take care of a follow-up across all files to unify this.
  16. Garvin Hicking commented on patch set 3 09/18/24, 12:28

    Index.rst:10 Reply