86132[BUGFIX] Fix the confirmation modal title for mass file deletion
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1923
-
Sébastien Delcroix uploaded patch set 1 09/17/24, 06:48
-
core-ci voted on patch set 1 V +1 09/17/24, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65947
-
Andreas Kienast commented on patch set 1 09/17/24, 07:13
-
Sébastien Delcroix commented on patch set 1 09/17/24, 07:19
locallang_mod_file_list.xlf:22ReplyThanks. I hesitated, because it can be folders too ;) Maybe "items" ? -
Andreas Kienast commented on patch set 1 09/17/24, 07:24
locallang_mod_file_list.xlf:22ReplyThat's of course correct. "Items" is IMO fine. -
Sébastien Delcroix uploaded patch set 2
V +109/17/24, 07:27 -
Sébastien Delcroix commented on patch set 2 09/17/24, 07:28
locallang_mod_file_list.xlf:22ReplyDone. -
core-ci voted on patch set 2 V +1 09/17/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65950
-
Sébastien Delcroix uploaded patch set 3
V +109/17/24, 10:13 -
Andreas Kienast voted on patch set 3 CR +1 09/17/24, 10:14
-
Sébastien Delcroix commented on patch set 3 09/17/24, 10:23
I just noticed that the "Close" button of the modal is using TYPO3.lang['button.close'] or 'Close' as a fallback, but it's always the fallback that is used. It seems that TYPO3.lang['button.close'] doesn't exist. Do I try to fix that in this patch ? I can also make the 'Close' button configurable via language files and replace it by "Cancel" while doing. -
core-ci voted on patch set 3 V +1 09/17/24, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65975
-
Christian Kuhn commented on patch set 3 09/17/24, 12:16
Reply
> I just noticed that the "Close" button of the modal is using TYPO3.lang['button.close'] or 'Close' as a fallback, but it's always the fallback that is used. > > It seems that TYPO3.lang['button.close'] doesn't exist. if this is the case, it probably happens in (many) further cases. if this is picked up, it should be a dedicated patch, maybe Andreas can comment if that's worth it. > I can also make the 'Close' button configurable via language files and replace it by "Cancel" while doing. i'd keep that for now.do you insist on v12? i'd kinda like to avoid new v12 labels and only do that if really needed. maybe that broken label in v12 does not kill kitten, and we could just keep it broken in v12? -
Sébastien Delcroix commented on patch set 3 09/17/24, 12:36
Reply
By "insist" do you mean something like "claim" ? Sorry in my native language "insist" has an "agressive" meaning of "someone who tries to force things", which I don't do here :) By the way, I'd like it to be fixed in v12 'cause we have many users, and regularly newcomers. But I'm not the one who decides :p If the patch is then restricted to main, I'll have to remove 12.4 from this commit line ? -
Christian Kuhn commented on patch set 3 09/17/24, 13:54
Reply
yeah. we basically decide on branches when doing the review for main, so we should sort this out, now. I'm essentially asking if that change is so important for you, that you really really want to have it in v12, or if we could leave v12 alone. The thing is: This change is from my point of view not crucially important and we could probably live with only fixing v13, without too much harm. I'm asking for your point of view on that. We *can* add new labels in v12, but it's not great to do so since it pushes pressure onto translaters maintaining "old" versions. v12 lifetime in general is getting closer to "important and security fixes only", so we rather try to reduce the number of backports we apply to this branch, from a core maintainer point of view. -
Sébastien Delcroix commented on patch set 3 09/17/24, 14:50
Reply
I don't know. It's a really simple issue (and I don't think that 2 or 3 labels will be much work or break things) but at the same time I understand your point of view ;) I don't think our users often delete files, maybe they don't even read the modal :p At worst, we'll override the language labels until we updrage to TYPO3v13. -
Sébastien Delcroix commented on patch set 3 09/17/24, 14:53
Reply
I also can handle the TYPO3.lang['button.close'] issue on another patch, targetting 12 and main. -
Sébastien Delcroix updated the commit message in patch set 4
CR +1V +109/18/24, 15:33 -
Team RVVN commented on patch set 3 09/18/24, 15:35
Reply
I've discovered that the wrong modal title was already in TYPO3v11, and our users have never complained, so it can wait. I've removed 12.4. -
core-ci voted on patch set 4 V +1 09/18/24, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66142
-
Christian Kuhn voted on patch set 4 CR +1 V +1 09/19/24, 22:09
-
Stefan Bürk commented on patch set 4 CR +2 V +2 09/20/24, 10:05
Reply
I'd say that this can be discussed and should be verified/fixed in a dedicated change. @sdelcroix@rvvn.org can you verify that, coordinate and create if reasonable a dedicated change for that ? -
Stefan Bürk merged patch set 5 09/20/24, 10:05
locallang_mod_file_list.xlf:22