Review main Merged

86133[BUGFIX] Fix type error on using addCacheTags

Karsten Nowak CR +2 V +2 Easy +1 −1 updated 09/17/24, 09:32

Commit message

Use the spread operator for the array_map result
in deprecated TSFE->addCacheTags().

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Sascha Nowak +1

Issues 2

Files 1

Review log 810

  1. Karsten Nowak uploaded patch set 1 09/17/24, 08:16

  2. core-ci voted on patch set 1 V +1 09/17/24, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65952

  3. Christian Kuhn updated the commit message in patch set 2 V +1 09/17/24, 09:08

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 09/17/24, 09:08

  5. Sascha Nowak voted on patch set 2 CR +1 V +1 09/17/24, 09:09

  6. Benjamin Franzke voted on patch set 2 CR +2 V +2 09/17/24, 09:15

  7. Benjamin Franzke merged patch set 3 09/17/24, 09:15

  8. Benjamin Franzke commented on patch set 3 09/17/24, 09:16

    Sorry, merged to early, didn't saw the edit 😞 (luckily only commit message was changed)
  9. core-ci voted on patch set 2 V +1 09/17/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65957

  10. Christian Kuhn commented on patch set 3 09/17/24, 09:32

    Reply

    yeah. all good. i voted up before green due to 'commit msg only' change.