Review main Abandoned

86134[WIP][TASK] Streamline TCA type=country implementation

Garvin Hicking CR 0 V 0 Normal +26 −42 updated 09/18/24, 09:35

Commit message

This patch tries to address issues reported as
post-merge -1 in #99911

After a possible revert, this can be joined into the
original patch.

Addressed:
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/77792/comment/992ddcdf_608ed864/
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/77792/comment/2f955641_cb6a25e1/
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/77792/comment/6dc0031e_40c9ca15/
- https://review.typo3.org/c/Packages/TYPO3.CMS/+/77792/comment/0ea18172_891bf077/

To discuss:
- Extbase type converter/mapping, to access a Country object properly?
- Multi-selection of more than one country?
- Flexform support

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 4

Review log 610

  1. Garvin Hicking uploaded patch set 1 09/17/24, 09:29

  2. core-ci voted on patch set 1 V +1 09/17/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65961

  3. Garvin Hicking uploaded patch set 2 V +1 09/17/24, 09:46

    Address superfluous inline evaluation
  4. core-ci voted on patch set 2 V -1 09/17/24, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65965

  5. Garvin Hicking uploaded patch set 3 V -1 09/17/24, 10:14

    address one phpstan issue
  6. Garvin Hicking uploaded patch set 4 09/17/24, 10:16

    Adjust RST
  7. Garvin Hicking uploaded patch set 5 09/17/24, 10:18

    Adjust datahandler comment
  8. core-ci voted on patch set 3 V -1 09/17/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65976

  9. core-ci voted on patch set 5 V -1 09/17/24, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65978

  10. Garvin Hicking abandoned the change 09/18/24, 09:35