Review main Merged

86135[TASK] Add `identifier` and `slideMode` to grid editor

Oli Bartsch CR +2 V +2 Normal +105 −11 updated 09/19/24, 10:01

Commit message

The grid editor allows to create a backend layout
via the UI. With #103894, the two new options
`identifier` and `slideMode` have been added
to the columns definition.

Since those options are important, especially the
`identifier`, the options are now available in the
grid editor.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1013

  1. Oli Bartsch uploaded patch set 1 09/17/24, 09:46

  2. Oli Bartsch uploaded patch set 2 09/17/24, 09:48

  3. core-ci voted on patch set 1 V +1 09/17/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65964

  4. core-ci voted on patch set 2 V +1 09/17/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65966

  5. Georg Ringer voted on patch set 2 CR +1 V +1 09/17/24, 18:47

  6. Benni Mack commented on patch set 2 09/18/24, 08:30

    locallang_wizards.xlf:103

    how about "the identifier is a human-readable unique label to be used to access the items in this column."
  7. Benni Mack voted on patch set 2 V +1 09/18/24, 08:36

  8. Oli Bartsch commented on patch set 3 CR +1 V +1 09/18/24, 08:39

    Published edit on patch set 2.
  9. Benni Mack commented on patch set 3 CR +1 V +1 09/18/24, 08:46

    locallang_wizards.xlf:103 Reply

    Done
  10. core-ci voted on patch set 3 V +1 09/18/24, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66109

  11. Georg Ringer voted on patch set 3 CR +1 V +1 09/19/24, 10:00

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 09/19/24, 10:01

  13. Oli Bartsch merged patch set 4 09/19/24, 10:01