Review main Merged

86146[TASK] Improve debug output of PAGEVIEW

Simon Praetorius CR +2 V +2 Easy +1 −1 updated 09/19/24, 12:39

Commit message

By moving `language` before `site` in the variables array,
`language` can be expanded in the `<f:debug>` ViewHelper,
which will make the `PAGEVIEW` object more approachable
for integrators.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Simon Praetorius uploaded patch set 1 09/17/24, 17:20

  2. core-ci voted on patch set 1 V +1 09/17/24, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66065

  3. Christian Kuhn commented on patch set 1 09/17/24, 19:38

    ? is this some dark magic of f:debug that changing the order is a solution?
  4. Simon Praetorius commented on patch set 1 09/17/24, 19:41

    Reply

    Kind of. It's more related to the `DebuggerUtility`. The first occurrence of an object can be expanded, following copies only refer to the first object and can't be opened. By switching the order, the outmost instance of the language object can be expanded.
  5. Nikita Hovratov voted on patch set 1 CR +1 09/18/24, 08:43

  6. Christian Kuhn commented on patch set 1 CR +1 V +1 09/18/24, 11:42

    Reply

    i see. and language is part of site as well ... that's unfortunate anyways, but can't be changed right now.
  7. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 09/18/24, 11:49

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 09/18/24, 11:49

  9. core-ci voted on patch set 2 V +1 09/18/24, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66123

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 09/18/24, 13:40

  11. Oli Bartsch merged patch set 3 09/18/24, 13:40

  12. Benjamin Franzke wrote 09/19/24, 12:39

    Created a revert of this change as Ie70564afd083bbd120f291aba07a20605e5574d0