Review main Merged

86147[BUGFIX] Show hash to user even if InstallTool password is invalid

Simon Praetorius CR +2 V +2 Easy +12 −4 updated 11/21/24, 19:29

Commit message

Currently, if a user uses an invalid InstallTool password hash,
for example a plaintext placeholder, the InstallTool login
throws an uncaught `InvalidPasswordHashException`.

This prevents the output of the generated hash based on
the entered password, which could then be used to fix the
issue by setting a valid InstallTool password in the
configuration.

With this change, the exception is caught and is written
to the log file instead. The user is shown the normal login
screen with the generated hash.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Andreas Nedbal +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2230

Show 45 earlier messages
  1. Simon Praetorius uploaded patch set 1 09/17/24, 17:48

  2. Simon Praetorius marked it work in progress 09/17/24, 17:48

  3. core-ci voted on patch set 1 V +1 09/17/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66067

  4. Simon Praetorius updated the commit message in patch set 2 V +1 09/17/24, 18:05

  5. Simon Praetorius marked it ready for review 09/17/24, 18:05

  1. core-ci voted on patch set 2 V +1 09/17/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66068

  2. Mathias Brodala commented on patch set 2 10/01/24, 10:01

    AuthenticationService.php:74

    Shouldn't this also lead to the login failed mail below?
  3. Simon Praetorius commented on patch set 2 10/01/24, 10:47

    AuthenticationService.php:74 Reply

    Would also be fine by me. The $validPassword line needs to be moved to the try {} block then.
  4. Simon Praetorius uploaded patch set 3 V +1 10/01/24, 11:06

  5. Simon Praetorius commented on patch set 3 10/01/24, 11:07

    AuthenticationService.php:74 Reply

    Done
  6. core-ci voted on patch set 3 V +1 10/01/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66887

  7. Markus Klein updated the commit message in patch set 4 V +1 10/01/24, 11:22

  8. Markus Klein voted on patch set 4 CR +1 10/01/24, 11:25

  9. core-ci voted on patch set 4 V +1 10/01/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66888

  10. Mathias Brodala commented on patch set 4 10/01/24, 11:40

    AuthenticationService.php:73

    IMO this should say "password hash" for clarity. And/or directly mention "BE/installToolPassword"?
  11. Andreas Nedbal voted on patch set 4 CR +1 V +1 11/21/24, 18:03

  12. Markus Klein rebased onto patch set 5 CR +1 V +1 11/21/24, 18:19

  13. Christian Kuhn commented on patch set 5 11/21/24, 18:24

    AuthenticationService.php:73 Reply

    Done
  14. Christian Kuhn uploaded patch set 6 11/21/24, 18:25

  15. core-ci voted on patch set 5 V +1 11/21/24, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69974

  16. Christian Kuhn updated the commit message in patch set 7 11/21/24, 18:25

  17. Christian Kuhn voted on patch set 7 CR +1 V +1 11/21/24, 18:26

  18. Simon Praetorius updated the commit message in patch set 8 CR +1 V +1 11/21/24, 18:27

  19. core-ci voted on patch set 7 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69976

  20. core-ci voted on patch set 6 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69975

  21. core-ci voted on patch set 8 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69977

  22. Christian Kuhn voted on patch set 8 CR +1 V +1 11/21/24, 18:36

  23. Andreas Nedbal voted on patch set 8 CR +1 V +1 11/21/24, 18:37

  24. Simon Praetorius voted on patch set 8 CR +2 V +2 11/21/24, 18:37

  25. Simon Praetorius merged patch set 9 11/21/24, 19:29