86147[BUGFIX] Show hash to user even if InstallTool password is invalid
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Andreas Nedbal +1
- Christian Kuhn +1
-
Verified V +2 Done
- Simon Praetorius +2
- Andreas Nedbal +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2230
Show 45 earlier messages
-
Simon Praetorius uploaded patch set 1 09/17/24, 17:48
-
Simon Praetorius marked it work in progress 09/17/24, 17:48
-
core-ci voted on patch set 1 V +1 09/17/24, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66067
-
Simon Praetorius updated the commit message in patch set 2
V +109/17/24, 18:05 -
Simon Praetorius marked it ready for review 09/17/24, 18:05
-
core-ci voted on patch set 2 V +1 09/17/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66068
-
Mathias Brodala commented on patch set 2 10/01/24, 10:01
-
Simon Praetorius commented on patch set 2 10/01/24, 10:47
AuthenticationService.php:74ReplyWould also be fine by me. The $validPassword line needs to be moved to the try {} block then. -
Simon Praetorius uploaded patch set 3
V +110/01/24, 11:06 -
Simon Praetorius commented on patch set 3 10/01/24, 11:07
AuthenticationService.php:74ReplyDone -
core-ci voted on patch set 3 V +1 10/01/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66887
-
Markus Klein updated the commit message in patch set 4
V +110/01/24, 11:22 -
Markus Klein voted on patch set 4 CR +1 10/01/24, 11:25
-
core-ci voted on patch set 4 V +1 10/01/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66888
-
Mathias Brodala commented on patch set 4 10/01/24, 11:40
AuthenticationService.php:73IMO this should say "password hash" for clarity. And/or directly mention "BE/installToolPassword"? -
Andreas Nedbal voted on patch set 4 CR +1 V +1 11/21/24, 18:03
-
Markus Klein rebased onto patch set 5
CR +1V +111/21/24, 18:19 -
Christian Kuhn commented on patch set 5 11/21/24, 18:24
AuthenticationService.php:73ReplyDone -
Christian Kuhn uploaded patch set 6 11/21/24, 18:25
-
core-ci voted on patch set 5 V +1 11/21/24, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69974
-
Christian Kuhn updated the commit message in patch set 7 11/21/24, 18:25
-
Christian Kuhn voted on patch set 7 CR +1 V +1 11/21/24, 18:26
-
Simon Praetorius updated the commit message in patch set 8
CR +1V +111/21/24, 18:27 -
core-ci voted on patch set 7 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69976
-
core-ci voted on patch set 6 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69975
-
core-ci voted on patch set 8 V +1 11/21/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69977
-
Christian Kuhn voted on patch set 8 CR +1 V +1 11/21/24, 18:36
-
Andreas Nedbal voted on patch set 8 CR +1 V +1 11/21/24, 18:37
-
Simon Praetorius voted on patch set 8 CR +2 V +2 11/21/24, 18:37
-
Simon Praetorius merged patch set 9 11/21/24, 19:29
AuthenticationService.php:74