Review main Merged

86149[BUGFIX] Do not "prep" record title in FormManagerController

Christian Kuhn CR +2 V +2 Normal +2 −62 updated 09/17/24, 20:54

Commit message

If a content element has an empty value in its `header` field,
the ext:form list module "References to this item" modal shows
`<em>[No title]</em>`. This is caused by `BU::getRecordTitle()`
that receives the `prep` argument being true.

The generated output is used in Fluid which escapes the content
anyway, therefore `prep` must not be set.

Also remove a useless abstraction with a heavily mocking test
that adds no value to this controller glue code.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Guido Schmechel +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1214

  1. Christian Kuhn uploaded patch set 1 09/17/24, 20:07

  2. Jasmina Ließmann voted on patch set 1 CR +1 V +1 09/17/24, 20:16

  3. Stefan Bürk voted on patch set 1 CR +1 09/17/24, 20:19

  4. Stefan Bürk voted on patch set 1 V +1 09/17/24, 20:20

  5. core-ci voted on patch set 1 V -1 09/17/24, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66072

  6. Guido Schmechel voted on patch set 1 CR +1 V +1 09/17/24, 20:23

  7. Christian Kuhn uploaded patch set 2 CR +1 V +1 09/17/24, 20:28

  8. Christian Kuhn commented on patch set 2 09/17/24, 20:28

    sorry. revotes please, missed the cgl change ...
  9. Guido Schmechel voted on patch set 2 CR +1 V +1 09/17/24, 20:29

  10. Stefan Bürk voted on patch set 2 CR +1 V +1 09/17/24, 20:29

  11. Jasmina Ließmann voted on patch set 2 CR +1 V +1 09/17/24, 20:29

  12. core-ci voted on patch set 2 V +1 09/17/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66074

  13. Christian Kuhn voted on patch set 2 CR +2 V +2 09/17/24, 20:54

  14. Christian Kuhn merged patch set 3 09/17/24, 20:54