Review main Merged

86151[TASK] Split a test fixture containing multiple classes

Christian Kuhn CR +2 V +2 Normal +164 −77 updated 09/17/24, 22:35

Commit message

Having multiple PHP classes in one file violates
PSR-4. Split a fixture file into multiple files
and adapt the test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/17/24, 21:12

  2. core-ci voted on patch set 1 V +1 09/17/24, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66079

  3. Christian Kuhn uploaded patch set 2 V +1 09/17/24, 22:10

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 09/17/24, 22:14

  5. core-ci voted on patch set 2 V +1 09/17/24, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66083

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 09/17/24, 22:27

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 09/17/24, 22:34

  8. Christian Kuhn merged patch set 3 09/17/24, 22:35