Review main Merged

86152Revert "[FEATURE] New TCA type "country""

Garvin Hicking CR +2 V +2 Hard +2 −806 updated 09/17/24, 11:04

Commit message

This reverts commit ad813a0d73a9f23c4934c55f1274b949cafba089.

Reason for revert: Post-merge, valid concerns were raised
that may make follow-ups after a sprint release too hard.

The most pressing one being processing via DataHandler and
regarding Record Transformation. For details, see the
currently unresolved comments in the original patch.

A follow-up patch has been created with #104997 which
can start the process on finishing the implementation.

Main points to address:

- DataHandler / Record Transformation (+Tests)
- FlexForm Support
- Possible multi-selection
- Extbase typeconverter implementation so that stored
  relations can be processed in frontend implementations
  of these records

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 79

  1. Garvin Hicking uploaded patch set 1 09/17/24, 10:38

  2. Garvin Hicking commented on patch set 1 09/17/24, 10:39

  3. Garvin Hicking updated the commit message in patch set 2 09/17/24, 10:42

  4. core-ci voted on patch set 1 V +1 09/17/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65985

  5. core-ci voted on patch set 2 V +1 09/17/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65987

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 09/17/24, 11:02

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 09/17/24, 11:03

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 09/17/24, 11:03

  9. Garvin Hicking merged patch set 3 09/17/24, 11:04