Review main Merged

86175[TASK] Make livesearch component context aware

Benjamin Kott CR +2 V +2 Hard +216 −196 updated 09/18/24, 09:22

Commit message

The new livesearch styling is context aware and
adapts to light and dark color schemes. The markup
was streamlined, workarounds dropped and now
features improved focus and hover styles.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1014

  1. Benjamin Kott uploaded patch set 1 09/18/24, 07:20

  2. Benjamin Kott uploaded patch set 2 09/18/24, 07:25

  3. core-ci voted on patch set 1 V +1 09/18/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66103

  4. core-ci voted on patch set 2 V +1 09/18/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66105

  5. Marvin Buchmann voted on patch set 2 V +1 09/18/24, 08:20

  6. Benjamin Kott uploaded patch set 3 V +1 09/18/24, 08:22

  7. Marvin Buchmann voted on patch set 3 V +1 09/18/24, 08:22

  8. Benjamin Franzke uploaded patch set 4 V +1 09/18/24, 08:24

  9. Benjamin Franzke commented on patch set 3 CR +1 V +1 09/18/24, 08:28

    column-selector-button.ts:186

    drive-by, but fine.
  10. core-ci voted on patch set 3 V +1 09/18/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66107

  11. core-ci voted on patch set 4 V +1 09/18/24, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66108

  12. Benjamin Franzke voted on patch set 4 CR +1 V +1 09/18/24, 08:41

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 09/18/24, 09:22

  14. Andreas Kienast merged patch set 5 09/18/24, 09:22