Review main Merged

86181[TASK] Remove usage named arguments in API method call

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 09/18/24, 13:31

Commit message

Remove usage of named argument in API calls
to BU::getProcessedValue() according to Core
docs: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CodingBestPractices/NamedArguments.html#invoking-core-api

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/18/24, 12:35

  2. core-ci voted on patch set 1 V +1 09/18/24, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66134

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 09/18/24, 12:56

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 09/18/24, 13:00

    It hurts a bit to let this go and make it an argument-eating monster, but rules are rules I guess :D
  5. Oli Bartsch voted on patch set 1 CR +2 V +2 09/18/24, 13:31

  6. Oli Bartsch merged patch set 2 09/18/24, 13:31