Review main Merged

86182[TASK] Make pagination context aware

Benjamin Kott CR +2 V +2 Hard +227 −129 updated 09/19/24, 10:54

Commit message

We are dropping the Bootstrap CSS definitions for
all paginations to have more control about the styling
of the pagination elements. From now on we are
shipping custom css adapted to our needs. The new
pagination element styling is context aware and adapts
to light and dark color schemes.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 912

  1. Benjamin Kott uploaded patch set 1 09/18/24, 12:38

  2. Benjamin Kott uploaded patch set 2 09/18/24, 12:51

  3. Andreas Kienast voted on patch set 2 CR +1 V +1 09/18/24, 12:53

  4. core-ci voted on patch set 2 V +1 09/18/24, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66137

  5. Benjamin Franzke uploaded patch set 3 CR +1 V +1 09/19/24, 09:42

  6. Benjamin Franzke commented on patch set 3 09/19/24, 09:42

    _element_pagination.scss:15

    The removal of `cursor: pointer` broke livesearch pagination cursors, I've added them for those components now, since `page-link` is currently used in too many placed (IMO) – for non-links. But that's a separate topic and therefore I'm ok with it.
  7. Benjamin Franzke uploaded patch set 4 CR +1 V +1 09/19/24, 09:46

  8. core-ci voted on patch set 3 V -1 09/19/24, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66191

  9. core-ci voted on patch set 4 V +1 09/19/24, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66193

  10. Benni Mack voted on patch set 4 CR +1 09/19/24, 10:05

  11. Andreas Kienast voted on patch set 4 CR +2 V +2 09/19/24, 10:54

  12. Andreas Kienast merged patch set 5 09/19/24, 10:54