86184[TASK] Use ClassMapGenerator from composer/class-map-generator
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 5
Review log 1924
-
Christian Kuhn uploaded patch set 1 09/18/24, 14:24
-
core-ci voted on patch set 1 V -1 09/18/24, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66140
-
Benjamin Franzke commented on patch set 1 09/18/24, 15:05
-
Christian Kuhn commented on patch set 1 09/19/24, 08:49
composer.json:36Replyhow to do that? -
Christian Kuhn commented on patch set 1 09/19/24, 09:11
composer.json:36Replygot it: we should leave it out from core/composer.json and have it in monorepo only. -
Christian Kuhn uploaded patch set 2
V -109/19/24, 10:20 -
Christian Kuhn uploaded patch set 3 09/19/24, 10:22
-
core-ci voted on patch set 2 V +1 09/19/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66196
-
core-ci voted on patch set 3 V +1 09/19/24, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66197
-
Christian Kuhn updated the commit message in patch set 4
V +109/19/24, 11:27 -
core-ci voted on patch set 4 V +1 09/19/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66204
-
Benjamin Franzke commented on patch set 4 09/19/24, 11:47
ClassMapGenerator.php:1With the removal of this file, ``` "classmap": [ "typo3/sysext/core/Resources/PHP/" ], ``` can be dropped from composer.json and typo3/sysext/core/composer.json -
Christian Kuhn uploaded patch set 5
V +109/19/24, 11:53 -
Christian Kuhn commented on patch set 4 09/19/24, 11:53
ClassMapGenerator.php:1Replyah. good catch. i kept that due to GlobalDebugFunctions.php, but that one is loaded via 'files'. -
Benjamin Franzke commented on patch set 4 09/19/24, 11:55
Good to migrate!Just want to mention: I think we do not test symlinked `typo3_src` or symlinked docroot (think versioned deployments) in functionals/acceptance tests. That's something I'd definitely try manually with custom extensions (that may also be symlinked into typo3conf/ext/) with this patch. -
Stefan Bürk commented on patch set 5 09/19/24, 12:01
Reply
system extension are symlinked in test instances `.../typo3/sysext/` - just the whole typo3 folder is not symlinked (and the index.php). So I guess that that should nearly test legacy mode correctly. But had the same thoughts too test this at least manually and on it ;) -
core-ci voted on patch set 5 V +1 09/19/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66206
-
Stefan Bürk commented on patch set 5 09/19/24, 12:50
Reply
Did different tests, but following uses kind of multiple symlinkins: ``` git clone https://github.com/TYPO3/typo3.git ./core-mono \ && cd core-mono \ && git fetch ssh://stefan.buerk@review.typo3.org:29418/Packages/TYPO3.CMS refs/changes/84/86184/5 && git cherry-pick FETCH_HEAD \ && Build/Scripts/runTests.sh -s composerInstall \ && cd .. \ && mkdir ./legacy \ && cd ./legacy \ && ln -s ../core-mono ./typo3_src-X.Y.Z \ && ln -s typo3_src-X.Y.Z typo3_src \ && ln -s typo3_src/index.php index.php \ && ln -s typo3_src/typo3 typo3 \ && touch FIRST_INSTALL \ && cd ../ \ && ln -s legacy ./legacy-project-symlinked ``` configured docroot onto `./legacy-project-symlinked` and run the installer (web) .. first page display a error because the folder is a symlink and must be an folder, but continue with error installs a functional system, and I can log into the backend. Than I symlinked a exenstion with custom backend module to it: ``` cd typo3conf/ext \ && ln -s ../../../test-extensions/test_backend_module ``` headed into the extension manager, activated that module and it worked. Did a similar test having the mono repo as `typo3_src` symlinked first before heading to the described variant above. And also on `./legacy` directly. Reset whole folders (typo3conf, typo3temp, fileadmin, ..) for each test. Legacy functional tests instances symlinks system extension into the typo3/sysext/folder: ``` cd typo3temp/var/tests/functional-0a32f04/typo3/sysext/ \ ls -l ``` which outputs on my system for example: ``` backend -> /var/www/work/t3c/core-main/core-main/typo3/sysext/backend/ core -> /var/www/work/t3c/core-main/core-main/typo3/sysext/core/ extbase -> /var/www/work/t3c/core-main/core-main/typo3/sysext/extbase/ fluid -> /var/www/work/t3c/core-main/core-main/typo3/sysext/fluid/ frontend -> /var/www/work/t3c/core-main/core-main/typo3/sysext/frontend/ redirects -> /var/www/work/t3c/core-main/core-main/typo3/sysext/redirects/ ``` and works pretty fine. From my point of view this change works for legacy mode. Or do you have setup variants which are even more trickier ? -
Stefan Bürk voted on patch set 5 CR +1 V +1 09/19/24, 17:22
-
Christian Kuhn commented on patch set 5 09/19/24, 18:16
Reply
this looks good to me, Stefan! Thanks for checking further combinations. Guess that's fine: setting comment to resolved. -
Garvin Hicking commented on patch set 5 CR +1 V +1 09/19/24, 18:58
LGTM. I applied the patch in both my monorepo legacy and a TDK/composer monorepo install, witnout seeing breakage. -
Benjamin Franzke voted on patch set 5 CR +1 09/20/24, 09:18
-
Christian Kuhn voted on patch set 5 CR +2 V +2 09/20/24, 09:20
-
Christian Kuhn merged patch set 6 09/20/24, 09:20
composer.json:36