Review main Merged

86185[TASK] Modernize DebuggerUtility::var_dump() rendering

Benjamin Franzke CR +2 V +2 Hard +264 −188 updated 09/20/24, 11:23

Commit message

Use a `html()` method similar to lit to avoid
string concatenation which has the potentional to
create broken or even insecure markup.

Also escape non printable characters in console
output mode.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1626

Show 1 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/18/24, 14:52

  1. core-ci voted on patch set 1 V -1 09/18/24, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66141

  2. Benjamin Franzke uploaded patch set 2 V -1 09/18/24, 20:24

  3. Benjamin Franzke uploaded patch set 3 09/18/24, 20:26

  4. core-ci voted on patch set 2 V -1 09/18/24, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66145

  5. core-ci voted on patch set 3 V -1 09/18/24, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66146

  6. Benjamin Franzke uploaded patch set 4 V -1 09/19/24, 03:29

  7. core-ci voted on patch set 4 V +1 09/19/24, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66151

  8. Benjamin Franzke uploaded patch set 5 V +1 09/19/24, 04:28

  9. core-ci voted on patch set 5 V +1 09/19/24, 04:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66156

  10. Benjamin Franzke voted on patch set 5 CR -1 09/19/24, 07:14

  11. Benjamin Franzke uploaded patch set 6 CR -1 V +1 09/19/24, 07:17

  12. core-ci voted on patch set 6 V +1 09/19/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66171

  13. Andreas Kienast voted on patch set 6 CR +1 09/19/24, 07:34

  14. Benjamin Franzke uploaded patch set 7 CR +1 V +1 09/19/24, 08:30

  15. core-ci voted on patch set 7 V +1 09/19/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66186

  16. Benjamin Franzke updated the commit message in patch set 8 V +1 09/19/24, 12:29

  17. core-ci voted on patch set 8 V +1 09/19/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66211

  18. Benjamin Franzke uploaded patch set 9 V +1 09/20/24, 06:43

  19. core-ci voted on patch set 9 V +1 09/20/24, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66288

  20. Benjamin Franzke uploaded patch set 10 09/20/24, 09:00

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  21. core-ci voted on patch set 10 V +1 09/20/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66299

  22. Andreas Kienast voted on patch set 10 CR +1 V +1 09/20/24, 09:22

  23. Stefan Bürk voted on patch set 10 CR +1 V +1 09/20/24, 11:09

  24. Benjamin Franzke voted on patch set 10 CR +2 V +2 09/20/24, 11:23

  25. Benjamin Franzke merged patch set 11 09/20/24, 11:23