Review main Merged

86186[BUGFIX] Cast URI to string to allow json encoding

Helmut Hummel CR +2 V +2 Easy +2 −2 updated 09/19/24, 06:10

Commit message

Otherwise the PHP object is transformed to an empty JS object
instead of a string containing the actual URI

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Helmut Hummel uploaded patch set 1 09/18/24, 22:09

  2. core-ci voted on patch set 1 V +1 09/18/24, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66147

  3. Garvin Hicking updated the commit message in patch set 2 V +1 09/19/24, 05:36

  4. Andreas Kienast updated the commit message in patch set 3 09/19/24, 05:36

  5. Andreas Kienast voted on patch set 3 CR +1 V +1 09/19/24, 05:36

  6. core-ci voted on patch set 2 V +1 09/19/24, 05:53 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66161

  7. core-ci voted on patch set 3 V +1 09/19/24, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66162

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 09/19/24, 06:10

  9. Garvin Hicking merged patch set 4 09/19/24, 06:10